Bug #96695 for Term-Cap: Test failure on HP-UX

Tue Jun 24 16:36:25 2014 GAAS [...] cpan.org - Ticket created

Subject:

Test failure on HP-UX

Running the test suite from Term-Cap-1.16 on one of our HP-UX B.11.23 machines I get:

$ perl test.pl
[...]

ok 23 - Tgetent() should die with bad termcap

ok 24 - Tgetent() should catch deep recursion

not ok 25 - Tgetent() should set a single field correctly

# Failed test 'Tgetent() should set a single field correctly'

# at test.pl line 147.

# got: undef

# expected: '1'

not ok 26 - Tgetent() should set another field on the same line

# Failed test 'Tgetent() should set another field on the same line'

# at test.pl line 148.

# got: undef

# expected: '1'

not ok 27 - Tgetent() should set a blank field correctly

# Failed test 'Tgetent() should set a blank field correctly'

# at test.pl line 149.

# got: undef

# expected: ''

not ok 28 - Tgetent() should set a key value pair correctly

# Failed test 'Tgetent() should set a key value pair correctly'

# at test.pl line 150.

# got: undef

# expected: 'v1'

ok 29 - Tgetent() should set and translate pairs

ok 30 - should set _pc field correctly
[...]

The only functional change in 1.16 <http://search.cpan.org/diff?from=Term-Cap-1.15&to=Term-Cap-1.16#Cap.pm> is:

-    unless ( @termcap_path || $entry )
+    if ( !@termcap_path || !$entry )

This isn't a valid transformation if you want the outcome of the test to be the same. If I replace the '||' with '&&' it should have the same behaviour as before; and if I do the test is happy again.

Was it intentional to change the behaviour of this expression?

Thu Jul 10 08:59:20 2014 shay [...] cpan.org - Correspondence added

I've now reported this on GitHub too. The change also caused failures in 'podlators' tests when merged into the perl core. https://github.com/jonathanstowe/Term-Cap/issues/3

Thu Jul 10 08:59:21 2014 The RT System itself - Status changed from 'new' to 'open'

Sat Jun 06 06:39:29 2015 jns [...] gellyfish.co.uk - Correspondence added

This should be fixed by the https://github.com/jonathanstowe/Term-Cap/commit/83b5bed895e7060786434065822cb5d6cf0ba316 - though as I am unable to test on HP-UX someone will need to test it and confirm.

Wed Jul 01 05:34:36 2015 jns [...] gellyfish.co.uk - Taken

Wed Jul 01 05:41:48 2015 jns [...] gellyfish.co.uk - Correspondence added

Hi, Thanks to the good offices of H. Merijn Brand I have an account on an HP-UX machine to test and will make an interim 1.17-RC1 shortly so others can test and if all good then make a proper release as soon as possible if all is well.

Wed Jul 01 06:20:32 2015 jns [...] gellyfish.co.uk - Correspondence added

Hi, 1.17-RC1 should be on CPAN now. It tests okay on HP-UX for me. If I don't hear otherwise I'll make a proper 1.17 release next week.

Mon Aug 17 02:32:32 2015 BULKDD [...] cpan.org - Correspondence added

On Wed Jul 01 06:20:32 2015, JSTOWE wrote: Show quoted text

> Hi, > 1.17-RC1 should be on CPAN now. It tests okay on HP-UX for me. > > If I don't hear otherwise I'll make a proper 1.17 release next week.

What is the status of getting this out on CPAN?

Mon Aug 17 03:27:07 2015 jonathan.stowe [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #96695] Test failure on HP-UX
Date:	Mon, 17 Aug 2015 08:26:49 +0100
To:	bug-Term-Cap [...] rt.cpan.org
From:	Jonathan Stowe <jonathan.stowe [...] gmail.com>

Hi, I haven't had any feedback as to whether it is any good or not, so I will release it today anyway. On Mon, 2015-08-17 at 02:32 -0400, Daniel Dragan via RT wrote: Show quoted text

> Queue: Term-Cap > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=96695 > > > On Wed Jul 01 06:20:32 2015, JSTOWE wrote:

> > Hi, > > 1.17-RC1 should be on CPAN now. It tests okay on HP-UX for me. > > > > If I don't hear otherwise I'll make a proper 1.17 release next week.

> > What is the status of getting this out on CPAN?

Sun Dec 04 15:20:13 2016 jns [...] gellyfish.co.uk - Correspondence added

fixed in 1.17

Sun Dec 04 15:20:18 2016 jns [...] gellyfish.co.uk - Status changed from 'open' to 'resolved'

Sun Dec 04 15:20:23 2016 jns [...] gellyfish.co.uk - Fixed in 1.17 added