| Subject: | bug in t/lib/Apache2/TestReload.pm; $r->args is undef now when no ? in QS |
2014-06-23 11:16:32 Mon $ svn diff t/lib/Apache2/TestReload.pm
Index: t/lib/Apache2/TestReload.pm
===================================================================
--- t/lib/Apache2/TestReload.pm (revision 1604706)
+++ t/lib/Apache2/TestReload.pm (working copy)
@@ -15,7 +15,8 @@
sub handler {
my $r = shift;
$pass++;
- if ($r->args eq 'last') {
+ my $args = $r->args;
+ if (defined $args && $r->args eq 'last') {
Apache2::Reload->unregister_module($package);
ModPerl::Util::unload_package($package);
$pass = 0;
===================================
2014-06-23 11:12:47 Mon $ t/TEST -verbose
/ntfhome/local/sbin/httpd -d /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t -f /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/conf/httpd.conf -D APACHE2 -D PERL_USEITHREADS
using Apache/2.2.27 (prefork MPM)
waiting 60 seconds for server to start: ..
waiting 60 seconds for server to start: ok (waited 0 secs)
server localhost:8529 started
[ info] adding source lib /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/../Apache-Test/lib to @INC
t/reload.t ..
1..3
# Running under perl version 5.020000 for linux
# Current time local: Mon Jun 23 11:12:58 2014
# Current time GMT: Mon Jun 23 18:12:58 2014
# Using Test.pm version 1.26
# Using Apache/Test.pm version 1.38
# writing file: /tmp/apache_test/Reload/Test.pm
# testing : Initial
# expected: const:const
# prototype:prototype
# simple:simple
# subpackage:subpackage
# received: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
# <html><head>
# <title>500 Internal Server Error</title>
# </head><body>
# <h1>Internal Server Error</h1>
# <p>The server encountered an internal error or
# misconfiguration and was unable to complete
# your request.</p>
# <p>Please contact the server administrator,
# you@example.com and inform them of the time the error occurred,
# and anything you might have done that may have
# caused the error.</p>
# <p>More information about this error may be available
# in the server error log.</p>
# </body></html>
not ok 1
# Failed test 1 in t/reload.t at line 39
# writing file: /tmp/apache_test/Reload/Test.pm
# testing : Reload
# expected: const:CONST
# prototype:PROTOTYPE
# simple:SIMPLE
# subpackage:SUBPACKAGE
# received: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
# <html><head>
# <title>500 Internal Server Error</title>
# </head><body>
# <h1>Internal Server Error</h1>
# <p>The server encountered an internal error or
# misconfiguration and was unable to complete
# your request.</p>
# <p>Please contact the server administrator,
# you@example.com and inform them of the time the error occurred,
# and anything you might have done that may have
# caused the error.</p>
# <p>More information about this error may be available
# in the server error log.</p>
# </body></html>
not ok 2
# Failed test 2 in t/reload.t at line 47
# testing : Unregister
# expected: unregistered OK
# received: unregistered OK
ok 3
# removing file: /tmp/apache_test/Reload/Test.pm
# removing dir tree: /tmp/apache_test/Reload
# removing dir tree: /tmp/apache_test
Failed 2/3 subtests
Test Summary Report
-------------------
t/reload.t (Wstat: 0 Tests: 3 Failed: 2)
Failed tests: 1-2
Files=1, Tests=3, 2 wallclock secs ( 0.06 usr 0.02 sys + 0.81 cusr 0.19 csys = 1.08 CPU)
Result: FAIL
Failed 1/1 test programs. 2/3 subtests failed.
[warning] server localhost:8529 shutdown
[ error] error running tests (please examine t/logs/error_log)
=============================================
2014-06-23 11:13:14 Mon $ cat t/logs/error_log
[Mon Jun 23 11:12:42 2014] [notice] Digest: generating secret for digest authentication ...
[Mon Jun 23 11:12:42 2014] [notice] Digest: done
[Mon Jun 23 11:12:42 2014] [notice] Apache/2.2.27 (Unix) mod_perl/2.0.9dev Perl/v5.20.0 configured -- resuming normal operations
[Mon Jun 23 11:12:42 2014] [info] Server built: Jun 22 2014 14:00:48
[Mon Jun 23 11:12:42 2014] [debug] prefork.c(1023): AcceptMutex: sysvsem (default: sysvsem)
[Mon Jun 23 11:12:45 2014] [error] [client 127.0.0.1] Use of uninitialized value in string eq at /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/lib/Apache2/TestReload.pm line 18.\n
[Mon Jun 23 11:12:45 2014] [error] [client 127.0.0.1] Use of uninitialized value in string eq at /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/lib/Apache2/TestReload.pm line 18.\n
[Mon Jun 23 11:12:45 2014] [info] removed PID file /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/logs/httpd.pid (pid=5408)
[Mon Jun 23 11:12:45 2014] [notice] caught SIGTERM, shutting down
[Mon Jun 23 11:12:56 2014] [notice] Digest: generating secret for digest authentication ...
[Mon Jun 23 11:12:56 2014] [notice] Digest: done
[Mon Jun 23 11:12:56 2014] [notice] Apache/2.2.27 (Unix) mod_perl/2.0.9dev Perl/v5.20.0 configured -- resuming normal operations
[Mon Jun 23 11:12:56 2014] [info] Server built: Jun 22 2014 14:00:48
[Mon Jun 23 11:12:56 2014] [debug] prefork.c(1023): AcceptMutex: sysvsem (default: sysvsem)
[Mon Jun 23 11:13:00 2014] [error] [client 127.0.0.1] Use of uninitialized value in string eq at /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/lib/Apache2/TestReload.pm line 18.\n
[Mon Jun 23 11:13:00 2014] [error] [client 127.0.0.1] Use of uninitialized value in string eq at /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/lib/Apache2/TestReload.pm line 18.\n
[Mon Jun 23 11:13:00 2014] [info] removed PID file /ntfhome/local/src/mod_perl2_svn/mod_perl/Apache-Reload/t/logs/httpd.pid (pid=5434)
[Mon Jun 23 11:13:00 2014] [notice] caught SIGTERM, shutting down