Bug #96586 for Net-SSLeay: Support for non c99 compilers

Fri Jun 20 09:10:48 2014 merijnb [...] cpan.org - Ticket created

Subject:

Support for non c99 compilers

You might close this as wontfix, and I wouldn't blame you, but I had to change SSLeay.xs, as the ancient compiler I am forced to use on one older platform did not support declaring variables after code. I did see PREINIT used in many other places, so I'm hoping you accept this patch, to make leave easier for us people stuck in the past. Diff: @@ -5453,12 +5453,13 @@ OCSP_RESPONSE *rsp SV *svreq unsigned long flags - CODE: + PREINIT: SSL_CTX *ctx; X509_STORE *store; OCSP_BASICRESP *bsr; OCSP_REQUEST *req = NULL; int i; + CODE: if (!ssl) croak("not a SSL object"); ctx = SSL_get_SSL_CTX(ssl);

Fri Jun 20 17:34:22 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #96586] Support for non c99 compilers
Date:	Sat, 21 Jun 2014 07:34:09 +1000
To:	"bug-Net-SSLeay [...] rt.cpan.org" <bug-Net-SSLeay [...] rt.cpan.org>
From:	Mike McCauley <mikem [...] airspayce.com>

Hi Thanks. I'm traveling at the moment and will look at it when I return Sent from my iPhone Show quoted text

> On 20 Jun 2014, at 11:10 pm, "Merijn Broeren via RT" <bug-Net-SSLeay@rt.cpan.org> wrote: > > Fri Jun 20 09:10:48 2014: Request 96586 was acted upon. > Transaction: Ticket created by MERIJNB > Queue: Net-SSLeay > Subject: Support for non c99 compilers > Broken in: 1.64 > Severity: Wishlist > Owner: Nobody > Requestors: merijnb@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=96586 > > > > You might close this as wontfix, and I wouldn't blame you, but I had to change SSLeay.xs, as the ancient compiler I am forced to use on one older platform did not support declaring variables after code. I did see PREINIT used in many other places, so I'm hoping you accept this patch, to make leave easier for us people stuck in the past. > > Diff: > > @@ -5453,12 +5453,13 @@ > OCSP_RESPONSE *rsp > SV *svreq > unsigned long flags > - CODE: > + PREINIT: > SSL_CTX *ctx; > X509_STORE *store; > OCSP_BASICRESP *bsr; > OCSP_REQUEST *req = NULL; > int i; > + CODE: > > if (!ssl) croak("not a SSL object"); > ctx = SSL_get_SSL_CTX(ssl); > >

Fri Jun 20 17:34:23 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 23 20:13:05 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #96586] Support for non c99 compilers
Date:	Tue, 24 Jun 2014 10:12:17 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, thanks for the suggestion. You suggested change is now in SVN 416 and will appear in the next release. Cheers. On Friday, June 20, 2014 09:10:50 AM you wrote: Show quoted text

> Fri Jun 20 09:10:48 2014: Request 96586 was acted upon. > Transaction: Ticket created by MERIJNB > Queue: Net-SSLeay > Subject: Support for non c99 compilers > Broken in: 1.64 > Severity: Wishlist > Owner: Nobody > Requestors: merijnb@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=96586 > > > > You might close this as wontfix, and I wouldn't blame you, but I had to > change SSLeay.xs, as the ancient compiler I am forced to use on one older > platform did not support declaring variables after code. I did see PREINIT > used in many other places, so I'm hoping you accept this patch, to make > leave easier for us people stuck in the past. > > Diff: > > @@ -5453,12 +5453,13 @@ > OCSP_RESPONSE *rsp > SV *svreq > unsigned long flags > - CODE: > + PREINIT: > SSL_CTX *ctx; > X509_STORE *store; > OCSP_BASICRESP *bsr; > OCSP_REQUEST *req = NULL; > int i; > + CODE: > > if (!ssl) croak("not a SSL object"); > ctx = SSL_get_SSL_CTX(ssl);

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Wed Aug 27 19:36:02 2014 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Aug 27 19:36:04 2014 MIKEM [...] cpan.org - Taken

Wed Aug 27 19:36:06 2014 MIKEM [...] cpan.org - Fixed in 1.65 added