Bug #96578 for Ogg-Vorbis-Header-PurePerl: Can't use an array as a reference

Fri Jun 20 00:06:25 2014 ANDK [...] cpan.org - Ticket created

Subject:

Can't use an array as a reference

Running the tests with perl v5.12.5 or higher is warning Using an array as a reference is deprecated at test.pl line 22. Using an array as a reference is deprecated at test.pl line 28. Using an array as a reference is deprecated at test.pl line 31. With bleadperl v5.21.0-417-g1f1ec7b this construct is deprecated, so with the next perl version, 5.22, O:V:H:PP will stop passing tests. Sample fail report: http://www.cpantesters.org/cpan/report/43357898 HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)

Mon Apr 06 21:49:33 2015 jkeenan [...] cpan.org - Correspondence added

On Fri Jun 20 00:06:25 2014, ANDK wrote: Show quoted text

> Running the tests with perl v5.12.5 or higher is warning > > Using an array as a reference is deprecated at test.pl line 22. > Using an array as a reference is deprecated at test.pl line 28. > Using an array as a reference is deprecated at test.pl line 31. > > With bleadperl v5.21.0-417-g1f1ec7b this construct is deprecated, so > with the next perl version, 5.22, O:V:H:PP will stop passing tests. > > Sample fail report: > > http://www.cpantesters.org/cpan/report/43357898 > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not > speaking as a user)

I am attaching a patch which should eliminate the warnings in perl-5.20 and earlier and prevent failures in perl-5.22. Thank you very much. Jim Keenan

Subject:

eliminate_deprecated_use_of_array_as_reference_rt_cpan_org_96578.diff

--- /home/jkeenan/Downloads/Ogg-Vorbis-Header-PurePerl-1.0/test.pl 2007-01-04 17:12:23.000000000 -0500 +++ ./test.pl 2015-04-06 21:44:12.970890513 -0400 @@ -19,16 +19,16 @@ # Try all the routines ok($ogg->info->{'rate'} == 44100); ok($ogg->comment_tags); -ok(@{$ogg->comment('artist')}->[0] == 'maloi'); +ok($ogg->comment('artist')->[0] == 'maloi'); $ogg = 0; # See if full load works ok(my $ogg = Ogg::Vorbis::Header::PurePerl->new('test.ogg')); -ok(@{$ogg->comment('artist')}->[0] == 'maloi'); +ok($ogg->comment('artist')->[0] == 'maloi'); # and see if we can get comments including the '=' character -ok(@{$ogg->comment('album')}->[0] == 'this=that'); +ok($ogg->comment('album')->[0] == 'this=that'); # Make sure we're getting the right track length ok($ogg->info->{'length'} == 0);

Mon Apr 06 21:49:33 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 13 08:29:32 2020 DAVECROSS [...] cpan.org - Taken

Mon Jul 13 08:30:08 2020 DAVECROSS [...] cpan.org - Correspondence added

Fixed in version 1.01 (currently en route to CPAN).

Mon Jul 13 08:30:16 2020 DAVECROSS [...] cpan.org - Status changed from 'open' to 'resolved'