Skip Menu |

This queue is for tickets about the Business-PayPal CPAN distribution.

Report information
The Basics
Id: 96521
Status: resolved
Priority: 0/
Queue: Business-PayPal

People
Owner: Nobody in particular
Requestors: viktor.nacht [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Business-PayPal Bug
Date: Wed, 18 Jun 2014 01:16:50 -0700
To: bug-Business-PayPal [...] rt.cpan.org
From: Viktor Nacht <viktor.nacht [...] gmail.com>
Please note that in the following code, you’re overwriting the @certs array with certcontent data, making it impossible to add valid certificates. if ($self->{addcert}) { push @certs, $self->{cert}; } if ($self->{addcertcontent}) { push @certs, $self->{certcontent}; } if ($self->{cert}) { @certs = $self->{cert}; } if ($self->{certcontent}) { @certs = $self->{certcontent}; } Also, please consider making the PayPal Sandbox an option by including the cert and making it an argument. I found the above bug when I was trying to test my code on their development server.
Subject: Re: [rt.cpan.org #96521] Business-PayPal Bug
Date: Wed, 18 Jun 2014 11:20:28 +0300
To: bug-Business-PayPal [...] rt.cpan.org
From: Gabor Szabo <SZABGAB [...] cpan.org>
thanks for reporting the bug. Could you also provide a test case for it, please? Gabor
Subject: Re: [rt.cpan.org #96521] Business-PayPal Bug
Date: Wed, 18 Jun 2014 01:32:39 -0700
To: bug-Business-PayPal [...] rt.cpan.org
From: Viktor Nacht <viktor.nacht [...] gmail.com>
For such a simple, obvious typo this doesn’t sound like a good use of time, sorry. For anyone finding this via Google, this is the fix: if ($self->{addcert}) { push @certs, $self->{cert}; } if ($self->{addcertcontent}) { push @cert_cont, $self->{certcontent}; } if ($self->{cert}) { @certs = $self->{cert}; } if ($self->{certcontent}) { @cert_cont = $self->{certcontent}; } On Jun 18, 2014, at 1:20, Gabor Szabo via RT <bug-Business-PayPal@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=96521 > > > thanks for reporting the bug. Could you also provide a test case for it, > please? > > Gabor >
Fixed in 0.18