Skip Menu |

This queue is for tickets about the namespace-autoclean CPAN distribution.

Report information
The Basics
Id: 96441
Status: resolved
Priority: 0/
Queue: namespace-autoclean
People
Owner: ether [...] cpan.org
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 0.16-TRIAL
  • 0.17
Fixed in: 0.18
Attachments
signature.asc

History Show all quoted text
  Fri Jun 13 19:19:19 2014 ANDK [...] cpan.org - Ticket created
Subject: 0.16 broke App::Sqitch
https://github.com/theory/sqitch/issues/169 Just a cross reference, I suppose.
  Fri Jun 13 19:22:32 2014 dwheeler [...] cpan.org - Correspondence added
On 2014-06-13 19:19:19, ANDK wrote: Show quoted text
> https://github.com/theory/sqitch/issues/169 > > Just a cross reference, I suppose.
Oh, is it namespace::autoclean that caused it? Oh well. Fixed in https://github.com/theory/sqitch/commit/8d291e12da5869e06973d14cc6da7c6bf8464978.
  Fri Jun 13 19:22:34 2014 The RT System itself - Status changed from 'new' to 'open'
  Fri Jun 13 20:27:11 2014 ether [...] cpan.org - Correspondence added
RT-Send-CC: dwheeler [...] cpan.org, ANDK [...] cpan.org
On 2014-06-13 16:22:32, DWHEELER wrote: Show quoted text
> On 2014-06-13 19:19:19, ANDK wrote: >
> > https://github.com/theory/sqitch/issues/169 > > > > Just a cross reference, I suppose.
> > Oh, is it namespace::autoclean that caused it? Oh well. Fixed in > https://github.com/theory/sqitch/commit/8d291e12da5869e06973d14cc6da7c6bf8464978.
Given that you're importing a 'color' sub, and you've got an attribute called 'color' too, I'm surprised your code *ever* worked :)
  Fri Jun 13 21:12:39 2014 dwheeler [...] cpan.org - Correspondence added
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #96441] 0.16 broke App::Sqitch
Date: Fri, 13 Jun 2014 17:44:54 -0700
To: bug-namespace-autoclean [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Jun 13, 2014, at 5:27 PM, Karen Etheridge via RT <bug-namespace-autoclean@rt.cpan.org> wrote: Show quoted text
> Given that you're importing a 'color' sub, and you've got an attribute called 'color' too, I'm surprised your code *ever* worked :)
Yeah, I was too. I think it worked before because of the function prototype. But anyway, better the way it is now, for sure. D
Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.

  Sat Jun 14 04:41:42 2014 haarg [...] haarg.org - Correspondence added
The problem here was that App::Sqitch uses Mouse, so 0.16 and 0.17 were trying to use Mouse's meta class to determine what needed to be cleaned. Previous versions used a Moose meta class, even for Mouse classes. Mouse's metaclass provides inaccurate information for the method list, so the color sub wasn't getting cleaned. My fix, at https://github.com/moose/namespace-autoclean/pull/4, is to just use the fallback heuristic instead of Mouse's metaclass. This should behave the same as the previous version that used Moose.
  Sun Jun 15 12:28:14 2014 ether [...] cpan.org - Correspondence added
On 2014-06-14 01:41:42, haarg wrote: Show quoted text
> The problem here was that App::Sqitch uses Mouse, so 0.16 and 0.17 > were trying to use Mouse's meta class to determine what needed to be > cleaned. Previous versions used a Moose meta class, even for Mouse > classes. Mouse's metaclass provides inaccurate information for the > method list, so the color sub wasn't getting cleaned. > > My fix, at https://github.com/moose/namespace-autoclean/pull/4, is to > just use the fallback heuristic instead of Mouse's metaclass. This > should behave the same as the previous version that used Moose.
I released 0.18 yesterday with this fix.
  Mon Jun 30 12:55:07 2014 ether [...] cpan.org - Taken
  Mon Jun 30 12:55:19 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Jun 30 12:55:19 2014 ether [...] cpan.org - Fixed in 0.18 added