Bug #96426 for MooseX-Storage: engine_traits performanceflaw

Hi ! We're using our own Storage traits with large ArrayRef of Moose Classes. We're used your Traits (e.g. OnlyWhenBuilt.pm) as an example which shows : $args{engine_traits} ||= []; push(@{$args{engine_traits}}, 'OnlyWhenBuilt'); $self->$orig(%args); This leads to performance problems due to the nature the %args of pack is 'arounded'. The following solved the problem : $self->$orig( %args, engine_traits => [ @{ $args{engine_traits} || [] }, 'PreserveUndef' ]); Explanation : For every Moose Object in the ArrayRef to be packed the the engine_traits List is extended because the %args ist _modified_ and so the @args of [ map { blessed($_) ? $OBJECT_HANDLERS{collapse}->($_, @args) : $_ } @$array ] Is modified too. If you find this useful you should modify your Traits the same way or maybe you have a better idea. Thank you, Mario