Skip Menu |

This queue is for tickets about the Net-DNS-Resolver-Programmable CPAN distribution.

Report information
The Basics
Id: 96390
Status: resolved
Priority: 0/
Queue: Net-DNS-Resolver-Programmable
People
Owner: Nobody in particular
Requestors: rwfranks [...] acm.org
Cc: davidp [...] preshweb.co.uk
AdminCc:
Bug Information
Severity: Critical
Broken in: v0.003
Fixed in: (no value)
Attachments
Programmable.pm-patch

History Show all quoted text
  Wed Jun 11 21:38:16 2014 rwfranks [...] acm.org - Ticket created
Subject: Module refers to non-existent %Net::DNS::rcodesbyname. [PATCH]
There are two separate issues here: 1) %Net::DNS::rcodesbyname is not, and never was, part of the published API for Net::DNS. 2) Even if it had been, the module contains no "use Net::DNS" directive and hence there is no guarantee that Net::DNS will be loaded or the table accessible. The table is only used to discriminate between a legitimate RCODE and an arbitrary error string. The numerical code values are not used at all. The table has now been removed from Net::DNS. The attached patch resolves both problems.
Subject: Programmable.pm-patch
Download Programmable.pm-patch
application/octet-stream 1.1k

Message body not shown because it is not plain text.

  Wed Jun 18 10:07:15 2014 davidp [...] preshweb.co.uk - Cc BIGPRESH added
  Tue Dec 08 17:43:32 2015 quanah.gibsonmount [...] gmail.com - Correspondence added
On Wed Jun 11 21:38:16 2014, rwfranks@acm.org wrote: Show quoted text
> There are two separate issues here: > > 1) %Net::DNS::rcodesbyname is not, and never was, part of the > published API for Net::DNS. > > 2) Even if it had been, the module contains no "use Net::DNS" > directive and hence there is no guarantee that Net::DNS will be loaded > or the table accessible. > > The table is only used to discriminate between a legitimate RCODE and > an arbitrary error string. The numerical code values are not used at > all. > The table has now been removed from Net::DNS. > > The attached patch resolves both problems.
This seems to be already fixed by the smaller patch in RT#95901?
  Tue Dec 08 17:43:32 2015 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 08 17:47:06 2015 quanah.gibsonmount [...] gmail.com - Correspondence added
On Tue Dec 08 17:43:32 2015, MISHIKAL wrote: Show quoted text
> On Wed Jun 11 21:38:16 2014, rwfranks@acm.org wrote:
> > There are two separate issues here: > > > > 1) %Net::DNS::rcodesbyname is not, and never was, part of the > > published API for Net::DNS. > > > > 2) Even if it had been, the module contains no "use Net::DNS" > > directive and hence there is no guarantee that Net::DNS will be loaded > > or the table accessible. > > > > The table is only used to discriminate between a legitimate RCODE and > > an arbitrary error string. The numerical code values are not used at > > all. > > The table has now been removed from Net::DNS. > > > > The attached patch resolves both problems.
> > This seems to be already fixed by the smaller patch in RT#95901?
Never mind, should apply that along with the bit in RT#95901 it looks like.
  Thu Jul 13 18:01:37 2017 davidp [...] preshweb.co.uk - Correspondence added
On 2014-06-12 02:38:16, rwfranks@acm.org wrote: Show quoted text
> There are two separate issues here: > > 1) %Net::DNS::rcodesbyname is not, and never was, part of the > published API for Net::DNS. > > 2) Even if it had been, the module contains no "use Net::DNS" > directive and hence there is no guarantee that Net::DNS will be loaded > or the table accessible. > > The table is only used to discriminate between a legitimate RCODE and > an arbitrary error string. The numerical code values are not used at > all. > The table has now been removed from Net::DNS. > > The attached patch resolves both problems.
Perfect, many thanks! I've just taken over maintainership of this module, and 0.005 will be hitting CPAN shortly with this patch - only 3 years later! :) Cheers Dave P
  Thu Jul 13 18:01:43 2017 davidp [...] preshweb.co.uk - Status changed from 'open' to 'resolved'