Skip Menu |

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 96384
Status: open
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: stuart [...] morungos.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 2.0110
  • 2.0111
  • 2.0112
  • 2.0113
  • 2.0114
  • 2.0115
  • 2.0116
Fixed in: (no value)



Subject: Non-numeric versions of ExtUtils::MakeMaker crash the build
Some versions of ExtUtils::MakeMaker report a non-numeric version, which breaks Makefile.PL. I just build a standard 5.14.2, and it includes EU::MM of version '6.57_05') which isn't numeric and therefore crashes the test '($ExtUtils::MakeMaker::VERSION >= 6.48)' in Makefile.PL. I'd suggest trimming everything after an underscore from the value before the comparison, as patch versioning in EE::MM shouldn't be influencing the API.
On 2014-06-11 13:07:07, SNKWATT wrote: Show quoted text
> Some versions of ExtUtils::MakeMaker report a non-numeric version, > which breaks Makefile.PL. I just build a standard 5.14.2, and it > includes EU::MM of version '6.57_05') which isn't numeric and > therefore crashes the test '($ExtUtils::MakeMaker::VERSION >= 6.48)' > in Makefile.PL. I'd suggest trimming everything after an underscore > from the value before the comparison, as patch versioning in EE::MM > shouldn't be influencing the API.
Wrap $ExtUtils::MakeMaker::VERSION in an eval, which will numify it.
On Wed Jun 11 16:07:07 2014, SNKWATT wrote: Show quoted text
> Some versions of ExtUtils::MakeMaker report a non-numeric version, > which breaks Makefile.PL. I just build a standard 5.14.2, and it > includes EU::MM of version '6.57_05') which isn't numeric and > therefore crashes the test '($ExtUtils::MakeMaker::VERSION >= 6.48)' > in Makefile.PL. I'd suggest trimming everything after an underscore > from the value before the comparison, as patch versioning in EE::MM > shouldn't be influencing the API.
Thanks for the report and sorry it took me so long to get to it - see https://github.com/shlomif/perl-XML-LibXML/tree/rt96384-non-numeric-eumm-vers for a branch with ETHER's fix. I'd like to merge it after the dust settles on the recent CVE.