Skip Menu |

This queue is for tickets about the Finance-Bank-Bankwest CPAN distribution.

Maintainer(s)' notes

This distribution provides the ability to log into Bankwest's Online Banking service using a Personal Access Number (PAN) and access code, then retrieve information on all accounts associated with that PAN and their transactions.

Report information
The Basics
Id: 96324
Status: resolved
Priority: 0/
Queue: Finance-Bank-Bankwest

People
Owner: lxp [...] cpan.org
Requestors: lxp [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.2.6
Fixed in: 1.2.7



Subject: test failures due to inability to find test fixtures
http://cpantesters.org/cpan/report/78956120-aeb9-11e3-b273-f2158806f0e4 Some tests failed with "resource does not exist" errors: Error GETing file://.../t/fixtures/txn-export.csv?...: File `.../t/fixtures/txn-export.csv?...' does not exist at .../lib/Finance/Bank/Bankwest/Session.pm line 75. Error GETing file://.../t/fixtures/acct-balances.html?...: File `.../t/fixtures/acct-balances.html?...' does not exist at .../lib/Finance/Bank/Bankwest/SessionFromLogin.pm line 52. These errors are triggered by this code in LWP::Protocol::file: https://metacpan.org/source/MSCHILLI/libwww-perl-6.06/lib/LWP/Protocol/file.pm#L50 It seems that an earlier version of this protocol might have treated the the query string as part of the filename. This failure doesn't exist in LWP::Protocol v6.00. Since the "file" protocol is only used by the tests, the appropriate fix seems to be to add a test dependency on the minimum version of LWP:: Protocol::file that GETs the fixtures correctly. Scanning through occurrences of the word "file" and "query" in the Changes file for libwww-perl didn't assist in finding a version addressing this issue. The next best step is probably to contact the person responsible for running the tests showing this failure, and see whether they can identify the version of libwww-perl that was running at the time.
Hi David, Thanks for your CPAN Testers participation, and for helping to improve the quality of the software available on CPAN. I'm contacting you regarding a report you submitted for the Finance:: Bank::Bankwest distribution at 2014-03-18T16:22:16Z. The report is located here: http://cpantesters.org/cpan/report/78956120-aeb9-11e3-b273-f2158806f0e4 but in short, it shows test failures that at this stage I suspect are caused by an older version of libwww-perl (LWP). I'd like to identify the minimum version of LWP needed for the tests to pass, and knowing what version of LWP was installed on your system when this test occurred would assist me. Unfortunately, since my distribution doesn't directly depend on LWP, the report doesn't provide me with this information. Are you able to advise me of the LWP version installed at the time of this test? Thanks for your time and attention. -- Kind regards, Alex Peters
Hi David, On Sun Jun 08 14:22:43 2014, LXP wrote: Show quoted text
> Are you able to advise me of the LWP version installed at the time of > this test?
Please disregard my earlier request; I've found the offending code in URI::file, not LWP. -- Kind regards, Alex Peters
On Sun Jun 08 14:08:57 2014, LXP wrote: Show quoted text
> It seems that an earlier version of this protocol might have treated > the query string as part of the filename. This failure doesn't exist > in LWP::Protocol v6.00. > > Since the "file" protocol is only used by the tests, the appropriate > fix seems to be to add a test dependency on the minimum version of > LWP::Protocol::file that GETs the fixtures correctly.
I've identified that the problem is actually caused by an old version of URI::file, not LWP::Protocol::file. Release 1.55 of the URI distribution includes the relevant fix: https://metacpan.org/changes/distribution/URI#L88 Annoyingly though, URI::file's version number wasn't bumped at the same time. The minimum version containing this fix is 4.21. Requiring URI::file v4.21 in the test code should solve this problem.