Hello CDrake,
Show quoted text > Here is the fix:-
>
> ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems
>
> Here is is again, in context:-
>
>
> sub setup_async {
> my ($self,$options) = @_;
> my $client = delete $options->{ client } || {};
> ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems
> $client->{port} ||= 4242;
> $client->{host} ||= 'localhost';
> $options->{log} ||= [];
>
>
>
> without the above, tests fail and it won't install or work.
>
I can't reproduce the problem. If I run this
# MOZREPL=192.168.1.92:4242 MOZREPL_CLASS=MozRepl::AnyEvent make test
on a machine that is not 192.168.1.92 , with Firefox running and mozrepl
listening on 192.168.1.92:4242 (with "allow outside connections") the
tests pass except for 01-expr.t.
At least when configuring the call to MozRepl::AnyEvent through the
environment instead of manually setting up the object it works. But I
see the t/expr-anyevent.t fails to properly set up (and respect) the
(possibly remote) $ENV{MOZREPL} settings, so there is a bug in the test.
Before I release the fixed version with the fixed test, can you please
elaborate on your setup and how you are using MozRepl::AnyEvent? The
parsing of $ENV{MOZREPL} is done in MozRepl::RemoteObject and
MozRepl::AnyEvent expects the options to be passed in as
MozRepl::RemoteObject does. If you want to use it separately, maybe it
would help to factor out the $ENV{}-parsing code to a separate subroutine...
-max
