Skip Menu |

This queue is for tickets about the version CPAN distribution.

Report information
The Basics
Id: 96100
Status: resolved
Priority: 0/
Queue: version

People
Owner: Nobody in particular
Requestors: fraserbn [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: prescan_version doesn't use it's context
prescan_version() is declared with pTHX_, but it never actually uses the context provided, and so produces warnings like this on a perl built with -Dusethreads and -Accflags="-Wunused-parameter": vutil.c: In function ‘Perl_prescan_version’: perl.h:154:22: warning: unused parameter ‘my_perl’ [-Wunused-parameter] # define pTHX tTHX my_perl PERL_UNUSED_DECL ^ perl.h:167:18: note: in expansion of macro ‘pTHX’ # define pTHX_ pTHX, ^ vutil.c:34:22: note: in expansion of macro ‘pTHX_’ Perl_prescan_version(pTHX_ const char *s, bool strict, Rather than changing the prototype and possibly breaking soemthing in the future, the best solution is probably adding a PERL_UNUSED_CONTEXT; next to the PERL_ARGS_ASSERT_PRESCAN_VERSION;
I just came here to say that I came here to report the same problem :-) PERL_UNUSED_CONTEXT would probably be the trick.
On Wed Jun 18 18:55:38 2014, JHI wrote: Show quoted text
> I just came here to say that I came here to report the same problem :-) > > PERL_UNUSED_CONTEXT would probably be the trick.
Thanks applied.