Skip Menu |

This queue is for tickets about the Time-HiRes CPAN distribution.

Report information
The Basics
Id: 96082
Status: resolved
Priority: 0/
Queue: Time-HiRes

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Descriptions for t/itimer.t
As per discussion on #p5p May 30 2014, here is a patch which provides descriptions for tests in t/itimer.t. If it is satisfactory, please let me know if you would like similar patches for the other test files. Thank you very much. Jim Keenan
Subject: itimer.diff
--- /home/jkeenan/learn/perl/p5p/timehires/Time-HiRes-1.9726/t/itimer.t 2012-02-01 12:10:31.000000000 -0500 +++ t/itimer.t 2014-05-30 09:16:35.866008045 -0400 @@ -43,7 +43,8 @@ # Assume interval timer granularity of $limit * 0.5 seconds. Too bold? my $virt = Time::HiRes::getitimer(&Time::HiRes::ITIMER_VIRTUAL); -ok defined $virt && abs($virt / 0.5) - 1 < $limit; +ok(defined $virt && abs($virt / 0.5) - 1 < $limit, + "ITIMER_VIRTUAL defined with sufficient granularity"); note "getitimer: ", join(" ", Time::HiRes::getitimer(&Time::HiRes::ITIMER_VIRTUAL)); @@ -57,7 +58,8 @@ Time::HiRes::getitimer(&Time::HiRes::ITIMER_VIRTUAL)); $virt = Time::HiRes::getitimer(&Time::HiRes::ITIMER_VIRTUAL); -ok defined $virt && $virt == 0; +ok(defined $virt && $virt == 0, + "ITIMER_VIRTUAL counted down successfully"); $SIG{VTALRM} = 'DEFAULT';
I have applied this patch — or at least the first hunk, as the second test had already been given a description by a previously-applied patch. Thanks! This will be in a dev release on the CPAN soon. -- rjbs