Skip Menu |

This queue is for tickets about the Net-AMQP CPAN distribution.

Report information
The Basics
Id: 96040
Status: open
Priority: 0/
Queue: Net-AMQP

People
Owner: Nobody in particular
Requestors: mlx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.06
Fixed in: (no value)



Subject: Net::AMQP::Protocol::full_docs_to_dir generates invalid file names on Win32
The test file t/50_autodocs.t fails on the call full_docs_to_dir due to trying to create files with names that, under Windows, request the creation of an alternate file stream. Files with ':' in the name refer to an alternate data stream under Windows (NTFS). See http://support.microsoft.com/kb/105763 as an example of this type of file.
From: twata_1 [...] yahoo.co.jp
Hi, I created a patch. I hope this helps. Thank you, -- twata On 2014-5月-28 水 15:01:57, midlifexis@wightmanfam.org wrote: Show quoted text
> The test file t/50_autodocs.t fails on the call full_docs_to_dir due > to trying to create files with names that, under Windows, request the > creation of an alternate file stream. > > Files with ':' in the name refer to an alternate data stream under > Windows (NTFS). See http://support.microsoft.com/kb/105763 as an > example of this type of file.
Subject: Net-AMQP-0.06.rt96040.patch
--- Net-AMQP-0.06/lib/Net/AMQP/Protocol.pm 2013-05-02 11:38:21.000000000 +0900 +++ Net-AMQP-0.06-patched/lib/Net/AMQP/Protocol.pm 2018-03-21 22:09:23.000000000 +0900 @@ -236,6 +236,7 @@ Using the dynamically generated classes, this will create 'pod' or 'pm' files in the target directory in the following format: $dir/Net::AMQP::Protocol::Basic::Publish.pod + $dir/Net_AMQP_Protocol_Basic_Publish.pod # under MS Windows (or with format 'pm') $dir/Net/AMQP/Protocol/Basic/Publish.pm @@ -257,6 +258,7 @@ if ($format eq 'pod') { $filename = File::Spec->catfile($dir, $method_class . '.pod'); + $filename =~ s{::}{_}g if $^O eq 'MSWin32'; } elsif ($format eq 'pm') { $filename = File::Spec->catfile($dir, $method_class . '.pm');