Skip Menu |

This queue is for tickets about the JSON-Any CPAN distribution.

Report information
The Basics
Id: 96034
Status: resolved
Priority: 0/
Queue: JSON-Any

People
Owner: ether [...] cpan.org
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.33
Fixed in: 1.34



Subject: Build requires Moose, because of Devel::StringInfo
The JSON::Any distribution has an indirect build dependency on Moose: - this makes an heavy dependency chain - this raises minimum perl to Moose requirement (5.8.3) This dependency comes from t/10_unicode.t that uses Devel::StringInfo that itself is implemented using Moose. -- Olivier Mengué - http://perlresume.org/DOLMEN
Le 2014-05-28 16:50:53, DOLMEN a écrit : Show quoted text
> The JSON::Any distribution has an indirect build dependency on Moose: > - this makes an heavy dependency chain > - this raises minimum perl to Moose requirement (5.8.3)
Devel::NYTProf is among the users of JSON::Any. https://github.com/timbunce/devel-nytprof/issues/30 -- Olivier Mengué - http://perlresume.org/DOLMEN
It appears that JSON::Any is the only user of Devel::StringInfo on CPAN, according to MetaCPAN: https://metacpan.org/requires/distribution/Devel-StringInfo -- Olivier Mengué - http://perlresume.org/DOLMEN
Here is the code that uses Devel::StringInfo: is( $thawed->[0], $text, "text is the same" ) || eval { require Devel::StringInfo; my $d = Devel::StringInfo->new; $d->dump_info( $text, name => "expected" ); $d->dump_info( $thawed->[0], name => "got" ); $d->dump_info($frozen); }; This code would work (and would not even change the output, as the most common case is that the test will pass) even if Devel::StringInfo was not installed as the require is guarded with an eval {}. So it should be possible to completely remove that dependency without impacting the existing code in any way. -- Olivier Mengué - http://perlresume.org/DOLMEN
Thanks, fixed in 1.34.
Le 2014-05-28 23:15:34, ETHER a écrit : Show quoted text
> Thanks, fixed in 1.34.
For reference, here is the commit: https://github.com/karenetheridge/JSON-Any/commit/bd2f0c67addcab0a62b7ce2ede4361ffad36cb6a -- Olivier Mengué - http://perlresume.org/DOLMEN