Skip Menu |

This queue is for tickets about the XML-Twig CPAN distribution.

Report information
The Basics
Id: 96009
Status: open
Priority: 0/
Queue: XML-Twig
People
Owner: Nobody in particular
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 3.48
Fixed in: (no value)

History Show all quoted text
  Tue May 27 11:19:33 2014 dolmen [...] cpan.org - Ticket created
Subject: Do not blindly forbid keep_atts_order if Tie::IxHash is missing
Tie::IxHash is currently needed to implement the option keep_atts_order. There is a check in the XML::Twig constructor to enforce that if the keep_atts_order option is used, XML::Twig fails early if Tie::IxHash is missing. Unfortunately the test is broken: it doesn't check what value is given to keep_atts_order. Which means that if the user sends (keep_atts_order => 0) XML::Twig will fail due to a missing Tie::IxHash (which is my case on my freshly build perl 5.20.0) while the point of the parameter was to explicitely disable the use of Tie::IxHash! Workaround: install Tie::IxHash -- Olivier Mengué - http://perlresume.org/DOLMEN
  Tue May 27 12:23:24 2014 xmltwig [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #96009] Do not blindly forbid keep_atts_order if Tie::IxHash is missing
Date: Tue, 27 May 2014 18:23:12 +0200
To: bug-XML-Twig [...] rt.cpan.org
From: mirod <xmltwig [...] gmail.com>
On 05/27/2014 05:19 PM, Olivier Mengué via RT wrote: Show quoted text
> Tie::IxHash is currently needed to implement the option > keep_atts_order. There is a check in the XML::Twig constructor to > enforce that if the keep_atts_order option is used, XML::Twig fails > early if Tie::IxHash is missing. > > Unfortunately the test is broken: it doesn't check what value is > given to keep_atts_order. Which means that if the user sends > (keep_atts_order => 0) XML::Twig will fail due to a missing > Tie::IxHash (which is my case on my freshly build perl 5.20.0) while > the point of the parameter was to explicitely disable the use of > Tie::IxHash! Workaround: install Tie::IxHash
Du! Fixed and tested on github and xmltwig.org Thanks. -- mirod
  Tue May 27 12:23:24 2014 The RT System itself - Status changed from 'new' to 'open'
  Wed May 28 05:04:13 2014 dolmen [...] cpan.org - Correspondence added
Le 2014-05-27 18:23:24, xmltwig@gmail.com a écrit : Show quoted text
> Fixed and tested on github and xmltwig.org
On xmltwig.org there is version 3.48 dated Tue May 27 18:09:38 2014. But this is the same version number as 3.48 on CPAN dated Mar 30. https://metacpan.org/changes/distribution/XML-Twig This is confusing. Did you miss to bump the version number? -- Olivier Mengué - http://perlresume.org/DOLMEN
  Wed May 28 06:39:29 2014 xmltwig [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #96009] Do not blindly forbid keep_atts_order if Tie::IxHash is missing
Date: Wed, 28 May 2014 12:39:12 +0200
To: bug-XML-Twig [...] rt.cpan.org
From: mirod <xmltwig [...] gmail.com>
On 05/28/2014 11:04 AM, Olivier Mengué via RT wrote: Show quoted text
> Queue: XML-Twig > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=96009 > > > Le 2014-05-27 18:23:24, xmltwig@gmail.com a écrit :
>> Fixed and tested on github and xmltwig.org
> > On xmltwig.org there is version 3.48 dated Tue May 27 18:09:38 2014. > But this is the same version number as 3.48 on CPAN dated Mar 30. > https://metacpan.org/changes/distribution/XML-Twig > > This is confusing. Did you miss to bump the version number?
Yes. Shame. I did not realize I had released 3.48 :--( Fixed. -- mirod