Skip Menu |

This queue is for tickets about the Graph-Similarity CPAN distribution.

Report information
The Basics
Id: 95943
Status: open
Priority: 0/
Queue: Graph-Similarity

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: v0.0.5
Fixed in: (no value)



Subject: Perl critic errors
The perlcritic test fails: # Failed test 'Test::Perl::Critic for "blib/lib/Graph/Similarity/CoupledNodeEdgeScoring.pm"' # at /opt/perl-5.18.2t/lib/site_perl/5.18.2/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/Graph/Similarity/CoupledNodeEdgeScoring.pm": # Private Member Data shouldn't be accessed directly at line 85, column 25. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) # Private Member Data shouldn't be accessed directly at line 85, column 52. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) # Private Member Data shouldn't be accessed directly at line 96, column 30. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) # Looks like you failed 1 test of 5. t/perlcritic.t ................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests
This test should not be running for normal user installs. Either move it to xt/, or guard it with: plan skip_all => 'this test is for authors only' unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};