Bug #95901 for Net-DNS-Resolver-Programmable: Use Net::DNS::Paramters::rcodebyname

Fri May 23 17:29:51 2014 NLNETLABS [...] cpan.org - Ticket created

Subject:

Use Net::DNS::Paramters::rcodebyname

Hi, You have used the undocumented internal Net::DNS::rcodesbyname in your package. This internal is no longer exposed since Net::DNS 0.75. I propose to also test for rcodes existence with $Net::DNS::Parameters::rcodebyname{$result} Mail-SPF unit tests are dependent on this, see: https://rt.cpan.org/Public/Bug/Display.html?id=95858 . See attached patch. Regards, -- Willem

Fri May 23 18:00:41 2014 NLNETLABS [...] cpan.org - Correspondence added

Curious, I didn't see the patch I attached, but I can copy/paste it in here as well: --- Programmable.pm.orig 2014-05-23 23:19:36.000000000 +0200 +++ Programmable.pm 2014-05-23 23:22:37.621007729 +0200 @@ -204,8 +204,10 @@ if (defined(my $resolver_code = $self->{resolver_code})) { ($result, $aa, @answer_rrs) = $resolver_code->($domain, $rr_type, $class); } - - if (not defined($result) or defined($Net::DNS::rcodesbyname{$result})) { + + if (not defined($result) + or defined($Net::DNS::rcodesbyname{$result} + or defined($Net::DNS::Parameters::rcodebyname{$result})) { # Valid RCODE, return a packet: $aa = TRUE if not defined($aa);

Sun Jun 29 10:34:45 2014 gregoa [...] cpan.org - Correspondence added

Here's the patch with one more closing parenthesis :)

Subject:

new-net-dns.patch

Description: deal with changes in Net::DNS >= 0.75 Origin: CPAN RT Bug: https://rt.cpan.org/Public/Bug/Display.html?id=95901 Bug-Debian: https://bugs.debian.org/752988 Author: Willen <NLNETLABS@cpan.org> Reviewed-by: gregor herrmann <gregoa@debian.org> Last-Update: 2014-06-29 --- a/lib/Net/DNS/Resolver/Programmable.pm +++ b/lib/Net/DNS/Resolver/Programmable.pm @@ -204,8 +204,10 @@ if (defined(my $resolver_code = $self->{resolver_code})) { ($result, $aa, @answer_rrs) = $resolver_code->($domain, $rr_type, $class); } - - if (not defined($result) or defined($Net::DNS::rcodesbyname{$result})) { + + if (not defined($result) + or defined($Net::DNS::rcodesbyname{$result}) + or defined($Net::DNS::Parameters::rcodebyname{$result})) { # Valid RCODE, return a packet: $aa = TRUE if not defined($aa);

Sun Jun 29 10:34:46 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Feb 06 05:12:44 2015 editor.buzzfeed [...] yahoo.com - Correspondence added

From:

editor.buzzfeed [...] yahoo.com

--- Programmable.pm.orig 2014-05-23 23:19:36.000000000 +0200 +++ Programmable.pm 2014-05-23 23:22:37.621007729 +0200 @@ -204,8 +204,10 @@ if (defined(my $resolver_code = $self->{resolver_code})) { ($result, $aa, @answer_rrs) = $resolver_code->($domain, $rr_type, $class); } - - if (not defined($result) or defined($Net::DNS::rcodesbyname{$result})) { + + if (not defined($result) + or defined($Net::DNS::rcodesbyname{$result} + or defined($Net::DNS::Parameters::rcodebyname{$result})) { # Valid RCODE, return a packet: $aa = TRUE if not defined($aa); ----------- Thanks, LissaCoffey - <a href="http://www.fixithere.net/" rel="bookmark">fixithere</a>

Mon Dec 21 17:12:45 2015 TODDR [...] cpan.org - Correspondence added

The new one we're using is the illegal call to internal %Net::DNS::Parameters::rcodebyname right? If so, then possibly check that one first to save lookups on people who are up to date?

Subject:

patch.txt

diff --git a/lib/Net/DNS/Resolver/Programmable.pm b/lib/Net/DNS/Resolver/Programmable.pm index 1af72ce..e09a2f0 100644 --- a/lib/Net/DNS/Resolver/Programmable.pm +++ b/lib/Net/DNS/Resolver/Programmable.pm @@ -203,8 +203,10 @@ sub send { if (defined(my $resolver_code = $self->{resolver_code})) { ($result, $aa, @answer_rrs) = $resolver_code->($domain, $rr_type, $class); } - - if (not defined($result) or defined($Net::DNS::rcodesbyname{$result})) { + + if (not defined($result) + or defined($Net::DNS::Parameters::rcodebyname{$result}) + or defined($Net::DNS::rcodesbyname{$result})) { # Valid RCODE, return a packet: $aa = TRUE if not defined($aa);

Thu Jul 13 18:05:42 2017 davidp [...] preshweb.co.uk - Correspondence added

0.005, hitting CPAN shortly, contains the patch from #96390, which I believe will fix this problem. I'm marking this as resolved, but please do correct me if there's a good reason to pull in Net::DNS::Parameters instead. Cheers Dave P

Thu Jul 13 18:05:48 2017 davidp [...] preshweb.co.uk - Status changed from 'open' to 'resolved'