Bug #95897 for Dist-Zilla-Plugin-Test-Compile: using perl path with perl- in names fails cases

Fri May 23 10:06:44 2014 eash [...] nvidia.com - Ticket created

CC:	"eddie [...] ashfamily.net" <eddie [...] ashfamily.net>
Subject:	using perl path with perl- in names fails cases
Date:	Fri, 23 May 2014 07:06:27 -0700
To:	"bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org" <bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org>
From:	Edward Ash <eash [...] nvidia.com>

I have a program that has the following perl path #!/home/utils/perl-5.16/5.16.2-nothreads-64/bin/perl This breaks the tests with the following error: t/00-compile.t ........... 3/5 # Failed test 'bin/rtltime_class.pl compiled ok' # at t/00-compile.t line 64. # got: '7424' # expected: '0' Unrecognized switch: -5.16/5.16.2-nothreads-64/bin/perl (-h will show valid options). at t/00-compile.t line 70, <GEN12> line 1. Thanks, Eddie ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------

Fri May 23 14:02:36 2014 ether [...] cpan.org - Correspondence added

On 2014-05-23 07:06:44, eash@nvidia.com wrote: Show quoted text

> I have a program that has the following perl path > #!/home/utils/perl-5.16/5.16.2-nothreads-64/bin/perl > This breaks the tests with the following error: > t/00-compile.t ........... 3/5 > # Failed test 'bin/rtltime_class.pl compiled ok' > # at t/00-compile.t line 64. > # got: '7424' > # expected: '0' > Unrecognized switch: -5.16/5.16.2-nothreads-64/bin/perl (-h will show > valid options). at t/00-compile.t line 70, <GEN12> line 1.

What version of the plugin are you using, and what architecture/operating system are you using? Can you attach the generated 00-compile.t test?

Fri May 23 14:02:36 2014 The RT System itself - Status changed from 'new' to 'open'

Fri May 23 14:03:11 2014 ether [...] cpan.org - Taken

Fri May 23 14:53:54 2014 eash [...] nvidia.com - Correspondence added

Subject:	RE: [rt.cpan.org #95897] using perl path with perl- in names fails cases
Date:	Fri, 23 May 2014 11:53:44 -0700
To:	"bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org" <bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org>
From:	Edward Ash <eash [...] nvidia.com>

I am using linux-x86 Version Dist::Zilla::Plugin::Test::Compile 2.0.040 Perl version : This is perl 5, version 16, subversion 2 (v5.16.2) built for x86_64-linux Show quoted text

-----Original Message----- From: Karen Etheridge via RT [mailto:bug-Dist-Zilla-Plugin-Test-Compile@rt.cpan.org] Sent: Friday, May 23, 2014 2:03 PM To: Edward Ash Subject: [rt.cpan.org #95897] using perl path with perl- in names fails cases <URL: https://rt.cpan.org/Ticket/Display.html?id=95897 > On 2014-05-23 07:06:44, eash@nvidia.com wrote:

> I have a program that has the following perl path > #!/home/utils/perl-5.16/5.16.2-nothreads-64/bin/perl > This breaks the tests with the following error: > t/00-compile.t ........... 3/5 > # Failed test 'bin/rtltime_class.pl compiled ok' > # at t/00-compile.t line 64. > # got: '7424' > # expected: '0' > Unrecognized switch: -5.16/5.16.2-nothreads-64/bin/perl (-h will show > valid options). at t/00-compile.t line 70, <GEN12> line 1.

What version of the plugin are you using, and what architecture/operating system are you using? Can you attach the generated 00-compile.t test? ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------

Message body is not shown because sender requested not to inline it.

Thu May 29 14:56:49 2014 eash [...] nvidia.com - Correspondence added

Subject:	RE: [rt.cpan.org #95897] using perl path with perl- in names fails cases
Date:	Thu, 29 May 2014 11:56:38 -0700
To:	"bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org" <bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org>
From:	Edward Ash <eash [...] nvidia.com>

To fix this line 55 of the .t file needs to change to close $fh and skip("$file isn't perl", 1) unless $line =~ /^#!.*?\bperl\b\s+(.*)$/; Show quoted text

-----Original Message----- From: Karen Etheridge via RT [mailto:bug-Dist-Zilla-Plugin-Test-Compile@rt.cpan.org] Sent: Friday, May 23, 2014 2:03 PM To: Edward Ash Subject: [rt.cpan.org #95897] using perl path with perl- in names fails cases <URL: https://rt.cpan.org/Ticket/Display.html?id=95897 > On 2014-05-23 07:06:44, eash@nvidia.com wrote:

> I have a program that has the following perl path > #!/home/utils/perl-5.16/5.16.2-nothreads-64/bin/perl > This breaks the tests with the following error: > t/00-compile.t ........... 3/5 > # Failed test 'bin/rtltime_class.pl compiled ok' > # at t/00-compile.t line 64. > # got: '7424' > # expected: '0' > Unrecognized switch: -5.16/5.16.2-nothreads-64/bin/perl (-h will show > valid options). at t/00-compile.t line 70, <GEN12> line 1.

What version of the plugin are you using, and what architecture/operating system are you using? Can you attach the generated 00-compile.t test? ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------

Thu May 29 15:46:04 2014 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #95897] using perl path with perl- in names fails cases
Date:	Thu, 29 May 2014 12:45:51 -0700
To:	Edward Ash via RT <bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Thu, May 29, 2014 at 02:56:49PM -0400, Edward Ash via RT wrote: Show quoted text

> Queue: Dist-Zilla-Plugin-Test-Compile > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95897 > > > To fix this line 55 of the .t file needs to change to > close $fh and skip("$file isn't perl", 1) unless $line =~ /^#!.*?\bperl\b\s+(.*)$/;

That's not quite the right fix, as your script is indeed perl. The regex simply isn't accurate enough in separating the executable name from the flags. I'll have a fix ready in the next day or so. In the meantime, you can use custom filefinders to exclude any problematic files from consideration by the test.

Fri May 30 13:57:32 2014 ether [...] cpan.org - Correspondence added

Shebang handling is now much more robust in 2.041.

Fri May 30 13:57:33 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Oct 23 17:56:23 2014 ether [...] cpan.org - Fixed in 2.041 added