Bug #95787 for Text-CSV_XS: csv2xls replaces 0 with blank cells?

Mon May 19 18:17:41 2014 justin [...] jacp1.com - Ticket created

Subject:	csv2xls replaces 0 with blank cells?
Date:	Mon, 19 May 2014 23:17:22 +0100
To:	bug-Text-CSV_XS [...] rt.cpan.org
From:	Justin Powell <justin [...] jacp1.com>

My csv2xls seems to replace plain 0 in a tab separated file with a blank cell in the xls output. This seems to be due to the line: my $val = $row[$c] || ""; Best regards, Justin

Tue May 20 01:50:34 2014 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #95787] csv2xls replaces 0 with blank cells?
Date:	Tue, 20 May 2014 07:50:18 +0200
To:	bug-Text-CSV_XS [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Mon, 19 May 2014 18:17:41 -0400, "Justin Powell via RT" <bug-Text-CSV_XS@rt.cpan.org> wrote: Show quoted text

> My csv2xls seems to replace plain 0 in a tab separated file with a blank > cell in the xls output. This seems to be due to the line: > > my $val = $row[$c] || "";

That should have been my $val = $row[$c] // ""; but 5.6.x does not support defined-or and 5.8.x does not without a patch. That line is in there since 0.41 (2008). Funny that it only showed now. Changed to my $val = defined $row[$c] ? $row[$c] : ""; Will be in next release. Thanks for the report. -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Tue May 20 01:50:34 2014 The RT System itself - Status changed from 'new' to 'open'

Tue May 20 01:54:11 2014 HMBRAND [...] cpan.org - Broken in 0.41 added

Tue May 20 01:54:11 2014 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Fri Jun 13 06:13:23 2014 HMBRAND [...] cpan.org - Fixed in 1.09 added

Fri Jun 13 06:13:25 2014 HMBRAND [...] cpan.org - Status changed from 'patched' to 'resolved'