Bug #95635 for CGI: CGI.pn: misprint in find

Wed May 14 06:37:55 2014 m.krayushin [...] net-probe.ru - Ticket created

Subject:	CGI.pn: misprint in find_tempdir subroutine
Date:	Wed, 14 May 2014 14:37:40 +0400
To:	bug-CGI [...] rt.cpan.org
From:	Maxim Krayushin <m.krayushin [...] net-probe.ru>

Hello, I've found a misprint in the CGI.pm module in find_tempdir subroutine: 4205c4205 < do {$TMPDIRECTORY = $_; last} if -d $_ && -w _; --- Show quoted text

> do {$TMPDIRECTORY = $_; last} if -d $_ && -w $_;

-- Best regards, Maxim Krayushin e-mail: m.krayushin@net-probe.ru skype: voodoovin web: www.net-probe.ru

Wed May 14 08:56:08 2014 mark [...] stosberg.com - Correspondence added

Subject:	Re: [rt.cpan.org #95635] CGI.pn: misprint in find_tempdir subroutine
Date:	Wed, 14 May 2014 05:55:55 -0700
To:	Maxim Krayushin via RT <bug-CGI [...] rt.cpan.org>
From:	Mark Stosberg <mark [...] stosberg.com>

Show quoted text

> < do {$TMPDIRECTORY = $_; last} if -d $_ && -w _; > ---

> > do {$TMPDIRECTORY = $_; last} if -d $_ && -w $_;

The existing code is correct and in fact better because it will run a bit faster. If you had creating a test case before you submitted, you would have seen that the existing code works as expected. See perldoc -f -X And scroll to the bottom to see "_" explained. Mark

Wed May 14 08:56:09 2014 The RT System itself - Status changed from 'new' to 'open'

Thu May 22 08:22:06 2014 LEEJO [...] cpan.org - Correspondence added

This issue has been copied to: https://github.com/leejo/CGI.pm/issues/135 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.

Thu May 22 11:38:00 2014 LEEJO [...] cpan.org - Correspondence added

Rejecting as per reasons explained above

Thu May 22 11:38:01 2014 LEEJO [...] cpan.org - Status changed from 'open' to 'rejected'

Bug #95635 for CGI: CGI.pn: misprint in find_tempdir subroutine

Preferred bug tracker