Bug #95597 for DBIx-Class-InflateColumn-Object-Enum: Use of uninitialized value $_ in anonymous hash for is_nullable enum

> > So we started to notice these warnings being produced after updating > > to > > 0.05 from DBIx-Class-InflateColumn-Object-Enum-0.04: > > ------------------------------------------------------ > > Use of uninitialized value $_ in anonymous hash ({}) at > > /usr/local/share/perl/5.14.2/ > > Object/Enum.pm line 160 > > ------------------------------------------------------ > > > > I took a look at the diff: > > http://search.cpan.org/diff?from=DBIx-Class-InflateColumn-Object- > > Enum- > > 0.04&to=DBIx-Class-InflateColumn-Object-Enum- > > 0.05#lib/DBIx/Class/InflateColumn/Object/Enum.pm > > > > In particular this code was added: > > ------------------------ > > push(@{$values}, undef) > > if defined($info->{is_nullable}) > > && $info->{is_nullable}; > > ------------------------ > > > > As can be seen, if is_nullable is set, undef is added to the list of > > values > > that are passed via this line further down: > > Object::Enum->new({values=>$values}). > > > > Then Object::Enum::new() does this: > > $gen->_values({ map { $_ => 1 } @{$arg->{values}} }); > > > > This spits out a warning, because of using undef as a hash key. Since > > undef > > gets converted down to an empty string, this seems to be a bug to me. > > > > I decided to patch this, however, there seems to be a lot of weird > > uses of > > the empty string as undef in this module's tests. I've attached my > > patch, > > but if you run the tests, you will see it breaking in lots of areas, > > because of empty string as undef. As far as I can tell, DBIx never > > inflates > > undef columns, so I'm not sure if this is being done to try and avoid > > that? > > > > Since I can't read minds and don't know what the intentions are for > > this > > module I felt I should just report this with my patch and the code to > > trigger the original problem and see what the author thinks the > > proper > > course of action is. (Both are attached.) > > > > Thanks, > > > > -- Josh Rosenbaum > > > > P.S. As a side note, if the original push into $values needs to be > > kept, we > > should probably make a copy of the array first so we don't modify the > > original one. So this line: > > my $values = $info->{extra}->{list}; > > would become something like: > > my $values = [ @{ $info->{extra}->{list} } ];