Bug #95527 for Net-SSLeay: [PATCH] missing format argument [-Werror=format-security]

Sat May 10 14:42:50 2014 gregoa [...] debian.org - Ticket created

Subject:	[PATCH] missing format argument [-Werror=format-security]
Date:	Sat, 10 May 2014 20:42:31 +0200
To:	bug-net-ssleay [...] rt.cpan.org
From:	gregor herrmann <gregoa [...] debian.org>

In Debian we are currently applying the attached patch to Net-SSLeay. We thought you might be interested in it, too. Description: fix build-failure on most Debian architectures: SSLeay.xs: In function 'XS_Net__SSLeay_OCSP_response_results': SSLeay.xs:5602:3: error: format not a string literal and no format arguments [-Werror=format-security] croak(error); ^ cc1: some warnings being treated as errors . Cf. https://buildd.debian.org/status/logs.php?pkg=libnet-ssleay-perl&ver=1.59-1 Origin: vendor Author: gregor herrmann <gregoa@debian.org> Last-Update: 2014-05-10 Thanks in advance, gregor herrmann, Debian Perl Group

Message body is not shown because sender requested not to inline it.

Sat May 10 14:50:49 2014 gregoa [...] cpan.org - Broken in 1.59 added

Sat May 10 14:52:18 2014 gregoa [...] cpan.org - Correspondence added

Oops, I messed up with quilt and added the diff to the wrong file. Here's the intended version.

Subject:

error-format-security.patch

Description: fix build-failure on most Debian architectures: SSLeay.xs: In function 'XS_Net__SSLeay_OCSP_response_results': SSLeay.xs:5602:3: error: format not a string literal and no format arguments [-Werror=format-security] croak(error); ^ cc1: some warnings being treated as errors . Cf. https://buildd.debian.org/status/logs.php?pkg=libnet-ssleay-perl&ver=1.59-1 Origin: vendor Bug: https://rt.cpan.org/Ticket/Display.html?id=95527 Forwarded: https://rt.cpan.org/Ticket/Display.html?id=95527 Author: gregor herrmann <gregoa@debian.org> Last-Update: 2014-05-10 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -5599,7 +5599,7 @@ if (certid) OCSP_CERTID_free(certid); if (error && !want_array) { OCSP_BASICRESP_free(bsr); - croak(error); + croak("%s", error); } } if (!want_array)

Sat May 10 14:52:18 2014 The RT System itself - Status changed from 'new' to 'open'

Sat May 10 17:41:28 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #95527] [PATCH] missing format argument [-Werror=format-security]
Date:	Sun, 11 May 2014 07:41:18 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks Gregor, Your recent patches are now in SVN 406 and new version 1.60 released. Cheers. On Saturday, May 10, 2014 02:52:18 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95527 > > > Oops, I messed up with quilt and added the diff to the wrong file. > > Here's the intended version.

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070

Sun May 11 07:19:13 2014 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #95527] [PATCH] missing format argument [-Werror=format-security]
Date:	Sun, 11 May 2014 13:18:18 +0200
To:	Mike McCauley via RT <bug-Net-SSLeay [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Sat, 10 May 2014 17:41:28 -0400, Mike McCauley via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=95527 > > > Thanks Gregor, > Your recent patches are now in SVN 406 and new version 1.60 released.

Thanks alot! I'm uploading 1.60 to Debian right now. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Guerra Fria 128

Download signature.asc
application/pgp-signature 928b

Message body not shown because it is not plain text.

Sat May 24 03:24:35 2014 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Sat May 24 03:24:36 2014 MIKEM [...] cpan.org - Taken