Skip Menu |

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 95466
Status: resolved
Priority: 0/
Queue: Encode
People
Owner: Nobody in particular
Requestors: nick [...] ccl4.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 2.53
  • 2.54
  • 2.55
  • 2.56
  • 2.57
  • 2.58
  • 2.59
  • 2.60
Fixed in: (no value)

History Show all quoted text
  Thu May 08 09:08:47 2014 nick [...] ccl4.org - Ticket created
Subject: fallback definition of SvIsCOW() is wrong (and hence breaks on 5.8.2 and earlier)
The fallback definition of SvIsCOW() added in (I think) 2.53 is wrong, and breaks the build if it is needed (perl 5.8.2 and earlier) I don't think that anyone is upgrading Encode on these rather old versions of Perl 5 :-) Patch attached corrects it. Nicholas Clark
Subject: SvIsCOW.patch
--- Encode.xs~ 2014-04-29 18:25:15.000000000 +0200 +++ Encode.xs 2014-05-08 15:01:11.753803181 +0200 @@ -840,7 +840,7 @@ RETVAL #ifndef SvIsCOW -# define SvIsCOW (SvREADONLY(sv) && SvFAKE(sv)) +# define SvIsCOW(sv) (SvREADONLY(sv) && SvFAKE(sv)) #endif SV *
  Thu May 08 11:16:56 2014 DANKOGAI [...] cpan.org - Correspondence added
Thanks, applied. https://github.com/dankogai/p5-encode/commit/159e38541a3bffff9a3156878da30190f50a778e Since Perl 5.8.2 is EOL'ed, I will keep from VERSION++ till more patches come... Dan the Encode Maintainer On Thu May 08 09:08:47 2014, nick@ccl4.org wrote: Show quoted text
> The fallback definition of SvIsCOW() added in (I think) 2.53 is wrong, > and > breaks the build if it is needed (perl 5.8.2 and earlier) > > I don't think that anyone is upgrading Encode on these rather old > versions of > Perl 5 :-) > > Patch attached corrects it. > > Nicholas Clark
  Thu May 08 11:16:57 2014 The RT System itself - Status changed from 'new' to 'open'
  Thu May 08 11:16:59 2014 DANKOGAI [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu May 08 11:21:38 2014 nick [...] ccl4.org - Correspondence added
Subject: Re: [rt.cpan.org #95466] fallback definition of SvIsCOW() is wrong (and hence breaks on 5.8.2 and earlier)
Date: Thu, 8 May 2014 16:21:23 +0100
To: Dan Kogai via RT <bug-Encode [...] rt.cpan.org>
From: Nicholas Clark <nick [...] ccl4.org>
On Thu, May 08, 2014 at 11:16:57AM -0400, Dan Kogai via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=95466 > > > Thanks, applied. > > https://github.com/dankogai/p5-encode/commit/159e38541a3bffff9a3156878da30190f50a778e > > Since Perl 5.8.2 is EOL'ed, I will keep from VERSION++ till more patches come...
That seems a sensible plan. Nicholas Clark