| Subject: | suspicious switch case in Dumper.xs (Coverity finding) |
| Date: | Tue, 06 May 2014 08:17:37 -0400 |
| To: | bug-Data-Dumper [...] rt.cpan.org |
| From: | Jarkko Hietaniemi <jhi [...] iki.fi> |
Suspicious = case1 + code + case2, without either flow control (break,
continue) or annotation (/* FALLTHROUGH */) between the code and case2.
Rationale: true fallthrough cases are rather rare, much more often break
is intended.
From 5-second inspection I assume this is an actually intentional
fall-through, so adding /* FALLTHROUGH */ would be the thing to do.
206 case '\'':
CID 28989 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: This case (value '\\') is not terminated by a 'break'
statement.
207 case '\\':
208 *d = '\\';
209 ++d; ++ret;
fallthrough: The above case falls through to this one.
210 default: