Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 95380
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: and [...] gmx.li
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: SSLeay.pod code example fix Net::SSLeay::initialize();
Hi, remove Net::SSLeay::initialize() from code examples, because we run initialize functions step-by-step. A following Net::SSLeay::initialize() would init all functions a second time because $library_initialised is not set yet. Upps, I forgot my signed-off-by line for the last two patches. Signed-off-by: Andreas Mohr <and@gmx.li> --- a/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 +++ b/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 @@ -497,8 +497,7 @@ Net::SSLeay::load_error_strings(); Net::SSLeay::SSLeay_add_ssl_algorithms(); - Net::SSLeay::randomize();Net::SSLeay::initialize(); - Net::SSLeay::initialize(); + Net::SSLeay::randomize(); Or even safer: @@ -508,7 +507,7 @@ BEGIN { Net::SSLeay::load_error_strings(); Net::SSLeay::SSLeay_add_ssl_algorithms(); - Net::SSLeay::randomize();Net::SSLeay::initialize(); + Net::SSLeay::randomize(); } =head3 Combining Net::SSLeay with other modules linked with openssl
Subject: Re: [rt.cpan.org #95380] SSLeay.pod code example fix Net::SSLeay::initialize();
Date: Tue, 06 May 2014 07:38:10 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Hi, thanks for the patch. Its now in SVN 402 and will appear in the next release. Cheers. On Monday, May 05, 2014 02:20:19 PM you wrote: Show quoted text
> Mon May 05 14:20:18 2014: Request 95380 was acted upon. > Transaction: Ticket created by and@gmx.li > Queue: Net-SSLeay > Subject: SSLeay.pod code example fix Net::SSLeay::initialize(); > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: and@gmx.li > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95380 > > > > Hi, > remove Net::SSLeay::initialize() from code examples, because we run > initialize functions step-by-step. > > A following Net::SSLeay::initialize() would init all functions a second time > because $library_initialised is not set yet. > > Upps, I forgot my signed-off-by line for the last two patches. > > Signed-off-by: Andreas Mohr <and@gmx.li> > > --- a/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 > +++ b/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 > @@ -497,8 +497,7 @@ > > Net::SSLeay::load_error_strings(); > Net::SSLeay::SSLeay_add_ssl_algorithms(); > - Net::SSLeay::randomize();Net::SSLeay::initialize(); > - Net::SSLeay::initialize(); > + Net::SSLeay::randomize(); > > Or even safer: > > @@ -508,7 +507,7 @@ > BEGIN { > Net::SSLeay::load_error_strings(); > Net::SSLeay::SSLeay_add_ssl_algorithms(); > - Net::SSLeay::randomize();Net::SSLeay::initialize(); > + Net::SSLeay::randomize(); > } > > =head3 Combining Net::SSLeay with other modules linked with openssl
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070
Subject: Re: [rt.cpan.org #95380] SSLeay.pod code example fix Net::SSLeay::initialize();
Date: Tue, 06 May 2014 07:38:11 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Hi, thanks for the patch. Its now in SVN 402 and will appear in the next release. We have also updated the signoff for your patches. Cheers. On Monday, May 05, 2014 02:20:19 PM you wrote: Show quoted text
> Mon May 05 14:20:18 2014: Request 95380 was acted upon. > Transaction: Ticket created by and@gmx.li > Queue: Net-SSLeay > Subject: SSLeay.pod code example fix Net::SSLeay::initialize(); > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: and@gmx.li > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95380 > > > > Hi, > remove Net::SSLeay::initialize() from code examples, because we run > initialize functions step-by-step. > > A following Net::SSLeay::initialize() would init all functions a second time > because $library_initialised is not set yet. > > Upps, I forgot my signed-off-by line for the last two patches. > > Signed-off-by: Andreas Mohr <and@gmx.li> > > --- a/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 > +++ b/lib/NetSSLeay.pod 2014-05-03 00:00:00.000000000 +0000 > @@ -497,8 +497,7 @@ > > Net::SSLeay::load_error_strings(); > Net::SSLeay::SSLeay_add_ssl_algorithms(); > - Net::SSLeay::randomize();Net::SSLeay::initialize(); > - Net::SSLeay::initialize(); > + Net::SSLeay::randomize(); > > Or even safer: > > @@ -508,7 +507,7 @@ > BEGIN { > Net::SSLeay::load_error_strings(); > Net::SSLeay::SSLeay_add_ssl_algorithms(); > - Net::SSLeay::randomize();Net::SSLeay::initialize(); > + Net::SSLeay::randomize(); > } > > =head3 Combining Net::SSLeay with other modules linked with openssl
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070