Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DateTime CPAN distribution.

Report information
The Basics
Id: 95345
Status: resolved
Priority: 0/
Queue: DateTime

People
Owner: Nobody in particular
Requestors: JETEVE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.09
Fixed in: 1.10



Subject: Breaks on perl 5.10 and 5.8
Arghh, the test suite doesn't pass with those Perl versions. I tracked it down to the fact that the epoch 95649120000 gives the year 69 (not 4001) in perl-5.8.9, thus the first test in t/46warnings.t not passing. I'm not sure of the best way to fix that. Maybe such an un-managed epoch shouldn't be allowed in the first place for those versions of perl?
On Sun May 04 10:49:19 2014, JETEVE wrote: Show quoted text
> Arghh, the test suite doesn't pass with those Perl versions. > > I tracked it down to the fact that the epoch 95649120000 gives the > year 69 (not 4001) in perl-5.8.9, thus the first test in > t/46warnings.t not passing. > > I'm not sure of the best way to fix that. Maybe such an un-managed > epoch shouldn't be allowed in the first place for those versions of > perl?
A bit more info: perlbrew exec perl -e 'print join(" : " , gmtime(95649120000))."\n";' perl-5.8.9 ========== 59 : 59 : 23 : 31 : 11 : 69 : 3 : 364 : 0 perl-5.14.4 ========== 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 perl-5.16.3 ========== 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 perl-5.18.2 ========== 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0
On Sun May 04 11:01:40 2014, JETEVE wrote: Show quoted text
> On Sun May 04 10:49:19 2014, JETEVE wrote:
> > Arghh, the test suite doesn't pass with those Perl versions. > > > > I tracked it down to the fact that the epoch 95649120000 gives the > > year 69 (not 4001) in perl-5.8.9, thus the first test in > > t/46warnings.t not passing. > > > > I'm not sure of the best way to fix that. Maybe such an un-managed > > epoch shouldn't be allowed in the first place for those versions of > > perl?
> > A bit more info: > > perlbrew exec perl -e 'print join(" : " , gmtime(95649120000))."\n";' > perl-5.8.9 > ========== > 59 : 59 : 23 : 31 : 11 : 69 : 3 : 364 : 0 > > > perl-5.14.4 > ========== > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 > > > perl-5.16.3 > ========== > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 > > > perl-5.18.2 > ========== > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0
I suspect the real issue is 64 bit integer support. I tried reproducing the failures I saw on my perlbrewed Perls and couldn't, but my Perl 5.8.8 is 64-bit. I think I can just do a feature test in the code for 64-bit support and skip the tests otherwise.
Sounds great. Yep, I've got a 32 bits perl 5.8: perl -v This is perl, v5.8.9 built for i686-linux Best, J On Sun May 04 11:44:37 2014, DROLSKY wrote: Show quoted text
> On Sun May 04 11:01:40 2014, JETEVE wrote:
> > On Sun May 04 10:49:19 2014, JETEVE wrote:
> > > Arghh, the test suite doesn't pass with those Perl versions. > > > > > > I tracked it down to the fact that the epoch 95649120000 gives the > > > year 69 (not 4001) in perl-5.8.9, thus the first test in > > > t/46warnings.t not passing. > > > > > > I'm not sure of the best way to fix that. Maybe such an un-managed > > > epoch shouldn't be allowed in the first place for those versions of > > > perl?
> > > > A bit more info: > > > > perlbrew exec perl -e 'print join(" : " , gmtime(95649120000))."\n";' > > perl-5.8.9 > > ========== > > 59 : 59 : 23 : 31 : 11 : 69 : 3 : 364 : 0 > > > > > > perl-5.14.4 > > ========== > > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 > > > > > > perl-5.16.3 > > ========== > > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0 > > > > > > perl-5.18.2 > > ========== > > 0 : 0 : 0 : 1 : 0 : 3101 : 4 : 0 : 0
> > I suspect the real issue is 64 bit integer support. I tried > reproducing the failures I saw on my perlbrewed Perls and couldn't, > but my Perl 5.8.8 is 64-bit. > > I think I can just do a feature test in the code for 64-bit support > and skip the tests otherwise.