Bug #95316 for Perl-Tags: Make PPI optional

Sat May 03 12:54:49 2014 DMITRI [...] cpan.org - Ticket created

Subject:

Make PPI optional

I think the naive parser does a good enough job. Having to use PPI makes this module uninstallable on Windows (strawberry Perl), at least for me: PPI fails to install. Also, tests in t/04_ppi.t are optional, but PPI is listed as required.

Sat May 03 15:21:08 2014 hakim.cassimally [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #95316] Make PPI optional
Date:	Sat, 3 May 2014 20:20:59 +0100
To:	bug-Perl-Tags [...] rt.cpan.org
From:	Hakim C <hakim.cassimally [...] gmail.com>

Sounds like a good idea, and should be simple enough to do -- have you got time to submit a patch? Otherwise I'll get around to that soonish. On 3 May 2014 17:54, Dmitri Tikhonov via RT <bug-Perl-Tags@rt.cpan.org>wrote: Show quoted text

> Sat May 03 12:54:49 2014: Request 95316 was acted upon. > Transaction: Ticket created by DMITRI > Queue: Perl-Tags > Subject: Make PPI optional > Broken in: 0.30 > Severity: Normal > Owner: Nobody > Requestors: DMITRI@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95316 > > > > I think the naive parser does a good enough job. Having to use PPI makes > this module uninstallable on Windows (strawberry Perl), at least for me: > PPI fails to install. > > Also, tests in t/04_ppi.t are optional, but PPI is listed as required. >

Sat May 03 15:21:08 2014 The RT System itself - Status changed from 'new' to 'open'

Sat May 03 15:28:56 2014 ether [...] cpan.org - Correspondence added

On 2014-05-03 09:54:49, DMITRI wrote: Show quoted text

> Having to use PPI > makes this module uninstallable on Windows (strawberry Perl), at least > for me: PPI fails to install.

Has it been reported to the PPI queue that it is not working on windows?

Sun May 04 09:03:56 2014 DMITRI [...] cpan.org - Correspondence added

On Sat May 03 15:21:08 2014, Hakim wrote: Show quoted text

> Sounds like a good idea, and should be simple enough to do -- have you > got time to submit a patch? Otherwise I'll get around to that soonish.

Sorry: not at the moment. I started doing it but then ran into some scripts in bin/ that use PPI. I don't yet understand what those scripts do and do not have time to delve deeper at the moment.

Sun May 04 09:07:22 2014 DMITRI [...] cpan.org - Correspondence added

On Sat May 03 15:28:56 2014, ETHER wrote: Show quoted text

> Has it been reported to the PPI queue that it is not working on windows?

Seems that the answer is no. PPI has a bunch of dependencies and one of them fails. Its tests all check out on windows according to cpantesters, so I am not sure what's up with that. I have no time now to look deeper.

Sun May 11 08:08:04 2014 osfameron [...] cpan.org - Correspondence added

On Sun May 04 09:07:22 2014, DMITRI wrote: Show quoted text

> On Sat May 03 15:28:56 2014, ETHER wrote:

> > Has it been reported to the PPI queue that it is not working on > > windows?

> > Seems that the answer is no. PPI has a bunch of dependencies and one > of them fails. Its tests all check out on windows according to > cpantesters, so I am not sure what's up with that. I have no time now > to look deeper.

making PPI optional also speeds up install and makes the fatpacked script for editor integration smaller, so I'm going with that for now. Fixed in git.

Sun May 11 08:08:06 2014 osfameron [...] cpan.org - Status changed from 'open' to 'patched'

Sun May 18 17:37:28 2014 osfameron [...] cpan.org - Correspondence added

On Sun May 11 08:08:04 2014, OSFAMERON wrote: Show quoted text

> On Sun May 04 09:07:22 2014, DMITRI wrote:

> > On Sat May 03 15:28:56 2014, ETHER wrote:

> > > Has it been reported to the PPI queue that it is not working on > > > windows?

> > > > Seems that the answer is no. PPI has a bunch of dependencies and one > > of them fails. Its tests all check out on windows according to > > cpantesters, so I am not sure what's up with that. I have no time > > now > > to look deeper.

> > making PPI optional also speeds up install and makes the fatpacked > script for editor integration smaller, so I'm going with that for now. > Fixed in git.

Sun May 18 17:37:29 2014 osfameron [...] cpan.org - Status changed from 'patched' to 'resolved'

Sun May 18 17:37:29 2014 osfameron [...] cpan.org - Fixed in 0.31 added