Skip Menu |

This queue is for tickets about the File-Copy-Undoable CPAN distribution.

Report information
The Basics
Id: 95194
Status: resolved
Priority: 0/
Queue: File-Copy-Undoable
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: (no value)

History Show all quoted text
  Wed Apr 30 02:53:41 2014 SREZIC [...] cpan.org - Ticket created
Subject: Does not work on FreeBSD
See http://matrix.cpantesters.org/?dist=File-Copy-Undoable There are no PASS reports for non-linux systems. Regards, Slaven
  Thu May 01 12:35:39 2014 sharyanto [...] cpan.org - Correspondence added
On Wed Apr 30 02:53:41 2014, SREZIC wrote: Show quoted text
> See http://matrix.cpantesters.org/?dist=File-Copy-Undoable > There are no PASS reports for non-linux systems. > > Regards, > Slaven
Some of these failures *might* be caused by File::Trash::FreeDesktop failing to trash files in some cases. I'm releasing a new version of it and will wait for further reports. Regards, Steven
  Thu May 01 12:35:39 2014 The RT System itself - Status changed from 'new' to 'open'
  Fri Jun 13 09:25:29 2014 sharyanto [...] cpan.org - Correspondence added
Hm, how come there are no tests on FreeBSD for 0.05. I've been waiting for over a month :-) http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
  Sat Jun 14 04:40:24 2014 SREZIC [...] cpan.org - Correspondence added
On 2014-06-13 09:25:29, SHARYANTO wrote: Show quoted text
> Hm, how come there are no tests on FreeBSD for 0.05. I've been waiting > for over a month :-) > > http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
There are problems along the dependency chain. File-Flock fails because of https://rt.cpan.org/Ticket/Display.html?id=93176 (probably depends whether the build is done as root or as an unprivileged user). Sys-Filesystem-MountPoint fails on systems with zfs as filesystem (which is the case on my FreeBSD 10 system), see https://rt.cpan.org/Ticket/Display.html?id=95192 . But I did some workarounds and now there are reports available.
  Fri Aug 28 16:41:02 2015 SREZIC [...] cpan.org - Correspondence added
On 2014-06-14 04:40:24, SREZIC wrote: Show quoted text
> On 2014-06-13 09:25:29, SHARYANTO wrote:
> > Hm, how come there are no tests on FreeBSD for 0.05. I've been > > waiting > > for over a month :-) > > > > http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
> > There are problems along the dependency chain. File-Flock fails > because of https://rt.cpan.org/Ticket/Display.html?id=93176 (probably > depends whether the build is done as root or as an unprivileged user). > Sys-Filesystem-MountPoint fails on systems with zfs as filesystem > (which is the case on my FreeBSD 10 system), see > https://rt.cpan.org/Ticket/Display.html?id=95192 . But I did some > workarounds and now there are reports available.
With 0.07 the t/owner_group-as_user.t test fails: # Failed test 'group still user's group' # at t/owner_group-as_user.t line 41. # got: '0' # expected: '1023' # Looks like you failed 1 test of 5. # Failed test 'after_do' # at /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm line 105. # Looks like you failed 1 test of 2. # Failed test 'copy' # at /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm line 504. # there are failing tests, not deleting test data dir /var/tmp/cpansmoker-1023/2015082818/FFS2GB8987 # Looks like you failed 1 test of 1. t/owner_group-as_user.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
  Fri Aug 28 17:04:06 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-08-28 16:41:02, SREZIC wrote: Show quoted text
> On 2014-06-14 04:40:24, SREZIC wrote:
> > On 2014-06-13 09:25:29, SHARYANTO wrote:
> > > Hm, how come there are no tests on FreeBSD for 0.05. I've been > > > waiting > > > for over a month :-) > > > > > > http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
> > > > There are problems along the dependency chain. File-Flock fails > > because of https://rt.cpan.org/Ticket/Display.html?id=93176 (probably > > depends whether the build is done as root or as an unprivileged > > user). > > Sys-Filesystem-MountPoint fails on systems with zfs as filesystem > > (which is the case on my FreeBSD 10 system), see > > https://rt.cpan.org/Ticket/Display.html?id=95192 . But I did some > > workarounds and now there are reports available.
> > With 0.07 the t/owner_group-as_user.t test fails: > > # Failed test 'group still user's group' > # at t/owner_group-as_user.t line 41. > # got: '0' > # expected: '1023' > # Looks like you failed 1 test of 5. > > # Failed test 'after_do' > # at /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > line 105. > # Looks like you failed 1 test of 2. > > # Failed test 'copy' > # at /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > line 504. > # there are failing tests, not deleting test data dir > /var/tmp/cpansmoker-1023/2015082818/FFS2GB8987 > # Looks like you failed 1 test of 1. > t/owner_group-as_user.t ... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests
The created temporary file has the group "wheel" (gid=0), which is not amongst the groups of the executing user. Reason is explained here <https://books.google.de/books?id=KfCuBAAAQBAJ&lpg=PA164&ots=u9vXtyKcY8&dq=freebsd%20group%20directory%20inherited&hl=hr&pg=PA164#v=onepage&q&f=false Show quoted text
>: "New files and directories inherit their groups from their parent directory at creation time." /tmp and /var/tmp belong to the group "wheel", so any directory and file created here will also belong to the group "wheel".
  Sat Aug 29 10:31:00 2015 PERLANCAR [...] cpan.org - Correspondence added
On Fri Aug 28 17:04:06 2015, SREZIC wrote: Show quoted text
> On 2015-08-28 16:41:02, SREZIC wrote:
> > On 2014-06-14 04:40:24, SREZIC wrote:
> > > On 2014-06-13 09:25:29, SHARYANTO wrote:
> > > > Hm, how come there are no tests on FreeBSD for 0.05. I've been > > > > waiting > > > > for over a month :-) > > > > > > > > http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
> > > > > > There are problems along the dependency chain. File-Flock fails > > > because of https://rt.cpan.org/Ticket/Display.html?id=93176 > > > (probably > > > depends whether the build is done as root or as an unprivileged > > > user). > > > Sys-Filesystem-MountPoint fails on systems with zfs as filesystem > > > (which is the case on my FreeBSD 10 system), see > > > https://rt.cpan.org/Ticket/Display.html?id=95192 . But I did some > > > workarounds and now there are reports available.
> > > > With 0.07 the t/owner_group-as_user.t test fails: > > > > # Failed test 'group still user's group' > > # at t/owner_group-as_user.t line 41. > > # got: '0' > > # expected: '1023' > > # Looks like you failed 1 test of 5. > > > > # Failed test 'after_do' > > # at > > /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > > line 105. > > # Looks like you failed 1 test of 2. > > > > # Failed test 'copy' > > # at > > /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > > line 504. > > # there are failing tests, not deleting test data dir > > /var/tmp/cpansmoker-1023/2015082818/FFS2GB8987 > > # Looks like you failed 1 test of 1. > > t/owner_group-as_user.t ... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/1 subtests
> > The created temporary file has the group "wheel" (gid=0), which is not > amongst the groups of the executing user. Reason is explained here > <https://books.google.de/books?id=KfCuBAAAQBAJ&lpg=PA164&ots=u9vXtyKcY8&dq=freebsd%20group%20directory%20inherited&hl=hr&pg=PA164#v=onepage&q&f=false
> > : "New files and directories inherit their groups from their parent > > directory at creation time." /tmp and /var/tmp belong to the group > > "wheel", so any directory and file created here will also belong to > > the group "wheel".
I've adjusted the test for this, and released 0.08.
  Sat Aug 29 10:31:01 2015 PERLANCAR [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Aug 29 11:40:18 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-08-29 10:31:00, PERLANCAR wrote: Show quoted text
> On Fri Aug 28 17:04:06 2015, SREZIC wrote:
> > On 2015-08-28 16:41:02, SREZIC wrote:
> > > On 2014-06-14 04:40:24, SREZIC wrote:
> > > > On 2014-06-13 09:25:29, SHARYANTO wrote:
> > > > > Hm, how come there are no tests on FreeBSD for 0.05. I've been > > > > > waiting > > > > > for over a month :-) > > > > > > > > > > http://matrix.cpantesters.org/?dist=File-Copy-Undoable+0.05
> > > > > > > > There are problems along the dependency chain. File-Flock fails > > > > because of https://rt.cpan.org/Ticket/Display.html?id=93176 > > > > (probably > > > > depends whether the build is done as root or as an unprivileged > > > > user). > > > > Sys-Filesystem-MountPoint fails on systems with zfs as filesystem > > > > (which is the case on my FreeBSD 10 system), see > > > > https://rt.cpan.org/Ticket/Display.html?id=95192 . But I did some > > > > workarounds and now there are reports available.
> > > > > > With 0.07 the t/owner_group-as_user.t test fails: > > > > > > # Failed test 'group still user's group' > > > # at t/owner_group-as_user.t line 41. > > > # got: '0' > > > # expected: '1023' > > > # Looks like you failed 1 test of 5. > > > > > > # Failed test 'after_do' > > > # at > > > /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > > > line 105. > > > # Looks like you failed 1 test of 2. > > > > > > # Failed test 'copy' > > > # at > > > /usr/perl5.20.0/lib/site_perl/5.20.0/Test/Perinci/Tx/Manager.pm > > > line 504. > > > # there are failing tests, not deleting test data dir > > > /var/tmp/cpansmoker-1023/2015082818/FFS2GB8987 > > > # Looks like you failed 1 test of 1. > > > t/owner_group-as_user.t ... > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/1 subtests
> > > > The created temporary file has the group "wheel" (gid=0), which is > > not > > amongst the groups of the executing user. Reason is explained here > > <https://books.google.de/books?id=KfCuBAAAQBAJ&lpg=PA164&ots=u9vXtyKcY8&dq=freebsd%20group%20directory%20inherited&hl=hr&pg=PA164#v=onepage&q&f=false
> > > : "New files and directories inherit their groups from their parent > > > directory at creation time." /tmp and /var/tmp belong to the group > > > "wheel", so any directory and file created here will also belong to > > > the group "wheel".
> > I've adjusted the test for this, and released 0.08.
Yes, seems to work now. I wonder if the same change needs to be done for other BSD systems. For some reason there are no reports at all for NetBSD, OpenBSD, DragonFly and kgnufreebsd, see http://matrix.cpantesters.org/?dist=File-Copy-Undoable;maxver=1 (maybe due to difficult dependencies?). Whether Mac OS X has the same problem is not clear; at least there was a pass report with an earlier File::Copy::Undoable version.