Skip Menu |

This queue is for tickets about the Module-Metadata CPAN distribution.

Maintainer(s)' notes

Attention bug reporters: issues MUST include the version of Module::Metadata that you are running that exhibit the stated symptoms. thank you!

Report information
The Basics
Id: 95086
Status: resolved
Priority: 0/
Queue: Module-Metadata
People
Owner: Nobody in particular
Requestors: miyagawa [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Apr 27 01:42:26 2014 miyagawa [...] gmail.com - Ticket created
Subject: Metadata.pm is encoded in latin-1
Date: Sat, 26 Apr 2014 22:41:58 -0700
To: bug-Module-Metadata [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Metadata.pm in the dist has a latin-1 encoded comment, which explodes Dist::Zilla, (?:::|\')? # possibly starting like just :: (Ì la $::VERSION) It is arguably a bug in dzil that explodes when encountering such bits that are not valid in utf-8, but given that line is just a comment, i'd want it to be encoded in either utf-8, or just use the ascii "a la". -- Tatsuhiko Miyagawa
  Sun Apr 27 02:30:41 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #95086] Metadata.pm is encoded in latin-1
Date: Sat, 26 Apr 2014 23:30:28 -0700
To: "miyagawa [...] gmail.com via RT" <bug-Module-Metadata [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Sun, Apr 27, 2014 at 01:42:28AM -0400, miyagawa@gmail.com via RT wrote: Show quoted text
> Metadata.pm in the dist has a latin-1 encoded comment, which explodes > Dist::Zilla, > > (?:::|\')? # possibly starting like just :: (Ì la $::VERSION) > > It is arguably a bug in dzil that explodes when encountering such bits > that are not valid in utf-8, but given that line is just a comment, > i'd want it to be encoded in either utf-8, or just use the ascii "a > la".
Please clarify "explodes Dist::Zilla"? The only time Dist::Zilla would be reading Metadata.pm is if the Module-Metadata dist were dzilified, which it isn't (not yet at least). If it were, the encoding of all files would be properly set with the [Encoding] plugin. What are you doing that causes Metadata.pm to interact with Dist::Zilla? Can you provide a stack trace?
  Sun Apr 27 02:30:42 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 27 02:33:25 2014 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #95086] Metadata.pm is encoded in latin-1
Date: Sat, 26 Apr 2014 23:32:52 -0700
To: bug-Module-Metadata [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
stack trace is at https://gist.github.com/miyagawa/11338261 I'm bundling Module::Metadata as a fatpacker with cpanm (dist.ini is on cpanminus repo if you're curious). I know it's an extremely rare use case. This has been reported to dist-zilla issue as well: https://github.com/rjbs/Dist-Zilla/issues/312 On Sat, Apr 26, 2014 at 11:30 PM, Karen Etheridge via RT <bug-Module-Metadata@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=95086 > > > On Sun, Apr 27, 2014 at 01:42:28AM -0400, miyagawa@gmail.com via RT wrote:
>> Metadata.pm in the dist has a latin-1 encoded comment, which explodes >> Dist::Zilla, >> >> (?:::|\')? # possibly starting like just :: (Ì la $::VERSION) >> >> It is arguably a bug in dzil that explodes when encountering such bits >> that are not valid in utf-8, but given that line is just a comment, >> i'd want it to be encoded in either utf-8, or just use the ascii "a >> la".
> > Please clarify "explodes Dist::Zilla"? The only time Dist::Zilla would be > reading Metadata.pm is if the Module-Metadata dist were dzilified, which it > isn't (not yet at least). If it were, the encoding of all files would be > properly set with the [Encoding] plugin. > > What are you doing that causes Metadata.pm to interact with Dist::Zilla? > Can you provide a stack trace? > >
-- Tatsuhiko Miyagawa
  Sun Apr 27 02:37:49 2014 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #95086] Metadata.pm is encoded in latin-1
Date: Sat, 26 Apr 2014 23:37:16 -0700
To: bug-Module-Metadata [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
if you're curious, i handpatched the file since that was blocking me to release cpanm (thought you're on that thread). https://github.com/miyagawa/cpanminus/commit/2887245b8b72aae142e647c7e528f83492b04dd3 This bug is a combination of: * fatpacker packs all files as they are, ending up mixing these different encodings in one file * dist-zilla parses these .pm files in a strict utf8 decoder which errors when finding such bits and fixing it in Module::Metadata will just be a workaround for this, but given that it is a comment and is one byte fix, I'd love to get it fixed. On Sat, Apr 26, 2014 at 11:30 PM, Karen Etheridge via RT <bug-Module-Metadata@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=95086 > > > On Sun, Apr 27, 2014 at 01:42:28AM -0400, miyagawa@gmail.com via RT wrote:
>> Metadata.pm in the dist has a latin-1 encoded comment, which explodes >> Dist::Zilla, >> >> (?:::|\')? # possibly starting like just :: (Ì la $::VERSION) >> >> It is arguably a bug in dzil that explodes when encountering such bits >> that are not valid in utf-8, but given that line is just a comment, >> i'd want it to be encoded in either utf-8, or just use the ascii "a >> la".
> > Please clarify "explodes Dist::Zilla"? The only time Dist::Zilla would be > reading Metadata.pm is if the Module-Metadata dist were dzilified, which it > isn't (not yet at least). If it were, the encoding of all files would be > properly set with the [Encoding] plugin. > > What are you doing that causes Metadata.pm to interact with Dist::Zilla? > Can you provide a stack trace? > >
-- Tatsuhiko Miyagawa
  Sun Apr 27 02:45:43 2014 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #95086] Metadata.pm is encoded in latin-1
Date: Sat, 26 Apr 2014 23:45:14 -0700
To: bug-Module-Metadata [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
I took the liberty with my commit bit to make a change on git repo :) http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/Module-Metadata.git;a=commitdiff;h=4955f7008c14360bb7e464002e6ad2ff7ed6a475
  Sun Apr 27 16:39:25 2014 ether [...] cpan.org - Correspondence added
On 2014-04-26 23:45:43, miyagawa@gmail.com wrote: Show quoted text
> I took the liberty with my commit bit to make a change on git repo :) > http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/Module- > Metadata.git;a=commitdiff;h=4955f7008c14360bb7e464002e6ad2ff7ed6a475
Wrong repo; I've moved that commit to the github repo. Release coming shortly.
  Sun Apr 27 16:39:27 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Apr 29 02:21:29 2014 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #95086] Metadata.pm is encoded in latin-1
Date: Tue, 29 Apr 2014 08:21:00 +0200
To: bug-Module-Metadata [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Thanks! On Sun, Apr 27, 2014 at 10:39 PM, Karen Etheridge via RT < bug-Module-Metadata@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=95086 > > > On 2014-04-26 23:45:43, miyagawa@gmail.com wrote:
> > I took the liberty with my commit bit to make a change on git repo :) > > http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/Module- > > Metadata.git;a=commitdiff;h=4955f7008c14360bb7e464002e6ad2ff7ed6a475
> > > Wrong repo; I've moved that commit to the github repo. Release coming > shortly. >
-- Tatsuhiko Miyagawa