Bug #95079 for Enbugger: Test fails with bleadperl

Sat Apr 26 16:36:55 2014 SREZIC [...] cpan.org - Ticket created

Subject:

Test fails with bleadperl

See http://matrix.cpantesters.org/?dist=Enbugger for an overview. It looks like a SIGABRT while running t/30break.t. Regards, Slaven

Sun Apr 27 12:01:55 2014 twists [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #95079] Test fails with bleadperl
Date:	Sun, 27 Apr 2014 09:01:41 -0700
To:	"bug-Enbugger [...] rt.cpan.org" <bug-Enbugger [...] rt.cpan.org>
From:	Joshua ben Jore <twists [...] gmail.com>

Just notes: $ gdb /home/josh/perl5/perlbrew/perls/perl-blead/bin/perl5.19.12 (gdb) set args -Mblib t/30break.pl (gdb) run Starting program: /home/josh/perl5/perlbrew/perls/perl-blead/bin/perl5.19.12 -Mblib t/ 30break.pl main::(t/30break.pl:138): $Value = 0; Program received signal SIGSEGV, Segmentation fault. Perl_av_fetch (av=0x0, key=146, lval=lval@entry=0) at av.c:240 240 assert(SvTYPE(av) == SVt_PVAV); (gdb) bt #0 Perl_av_fetch (av=0x0, key=146, lval=lval@entry=0) at av.c:240 #1 0x081199ae in Perl_magic_setdbline (sv=0x89455f0, mg=0x8b05a20) at mg.c:2008 #2 0x08115adc in Perl_mg_set (sv=sv@entry=0x89455f0) at mg.c:279 #3 0x08132855 in Perl_pp_sassign () at pp_hot.c:224 #4 0x0810b6cd in Perl_runops_debug () at dump.c:2428 #5 0x0808c815 in S_run_body (oldscope=1) at perl.c:2451 #6 perl_run (my_perl=0x82f2008) at perl.c:2372 #7 0x080613fd in main (argc=3, argv=0xbffff544, env=0xbffff554) at perlmain.c:114 J On Sat, Apr 26, 2014 at 1:36 PM, Slaven_Rezic via RT < bug-Enbugger@rt.cpan.org> wrote: Show quoted text

> Sat Apr 26 16:36:55 2014: Request 95079 was acted upon. > Transaction: Ticket created by SREZIC > Queue: Enbugger > Subject: Test fails with bleadperl > Broken in: 2.015 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95079 > > > > See http://matrix.cpantesters.org/?dist=Enbugger for an overview. It > looks like a SIGABRT while running t/30break.t. > > Regards, > Slaven >

Sun Apr 27 12:01:55 2014 The RT System itself - Status changed from 'new' to 'open'

Tue May 13 14:49:12 2014 ANDK [...] cpan.org - Correspondence added

Also reported to p5p at https://rt.perl.org/Ticket/Display.html?id=121862

Wed May 14 21:34:36 2014 TONYC [...] cpan.org - Correspondence added

On Sat Apr 26 16:36:55 2014, SREZIC wrote: Show quoted text

> See http://matrix.cpantesters.org/?dist=Enbugger for an overview. It > looks like a SIGABRT while running t/30break.t. > > Regards, > Slaven

5.20 to-be expects some extra information in the magic set on the %{"_<$filename"} hashes, please see the rt.perl.org ticket for a longer explanation. I've attached the same patch as I did to the rt.perl.org ticket. Tony

Subject:

Enbugger.diff

diff -ru Enbugger-2.016-orig/Enbugger.xs Enbugger-2.016/Enbugger.xs --- Enbugger-2.016-orig/Enbugger.xs 2014-04-26 01:58:29.000000000 +1000 +++ Enbugger-2.016/Enbugger.xs 2014-05-15 10:51:28.000000000 +1000 @@ -231,13 +231,12 @@ Enbugger_set_magic_dbfile(rv) SV *rv INIT: - HV *hv; + GV *gv; CODE: assert(SvROK(rv)); - - hv = (HV*) SvRV(rv); - assert(SVt_PVHV == SvTYPE(hv)); - hv_magic(hv, NULL, PERL_MAGIC_dbfile); + gv = (GV*)SvRV(rv); + assert(SVt_PVGV == SvTYPE(gv)); + hv_magic(GvHVn(gv), GvAVn(gv), PERL_MAGIC_dbfile); diff -ru Enbugger-2.016-orig/lib/Enbugger.pm Enbugger-2.016/lib/Enbugger.pm --- Enbugger-2.016-orig/lib/Enbugger.pm 2014-04-26 01:58:29.000000000 +1000 +++ Enbugger-2.016/lib/Enbugger.pm 2014-05-15 10:51:28.000000000 +1000 @@ -356,11 +356,11 @@ if ( not defined $file ) { *DB::dbline = []; *DB::dbline = {}; - Enbugger::set_magic_dbfile( \%DB::dbline ); } else { no strict 'refs'; *DB::dbline = \*{"main::_<$file"}; + Enbugger::set_magic_dbfile( \*DB::dbline ); } } @@ -399,8 +399,8 @@ if ( ! *$glob{HASH} ) { my %breakpoints; - Enbugger::set_magic_dbfile(\%breakpoints); *$glob = \%breakpoints; + Enbugger::set_magic_dbfile($glob); } $$symname ||= $file;

Wed May 14 21:35:33 2014 twists [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #95079] Test fails with bleadperl
Date:	Wed, 14 May 2014 18:35:23 -0700
To:	bug-Enbugger [...] rt.cpan.org
From:	Joshua ben Jore <twists [...] gmail.com>

Thank you. On May 14, 2014 6:34 PM, "TONYC via RT" <bug-Enbugger@rt.cpan.org> wrote: Show quoted text

> Queue: Enbugger > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=95079 > > > On Sat Apr 26 16:36:55 2014, SREZIC wrote:

> > See http://matrix.cpantesters.org/?dist=Enbugger for an overview. It > > looks like a SIGABRT while running t/30break.t. > > > > Regards, > > Slaven

> > 5.20 to-be expects some extra information in the magic set on the > %{"_<$filename"} hashes, please see the rt.perl.org ticket for a longer > explanation. > > I've attached the same patch as I did to the rt.perl.org ticket. > > Tony > > diff -ru Enbugger-2.016-orig/Enbugger.xs Enbugger-2.016/Enbugger.xs > --- Enbugger-2.016-orig/Enbugger.xs 2014-04-26 01:58:29.000000000 +1000 > +++ Enbugger-2.016/Enbugger.xs 2014-05-15 10:51:28.000000000 +1000 > @@ -231,13 +231,12 @@ > Enbugger_set_magic_dbfile(rv) > SV *rv > INIT: > - HV *hv; > + GV *gv; > CODE: > assert(SvROK(rv)); > - > - hv = (HV*) SvRV(rv); > - assert(SVt_PVHV == SvTYPE(hv)); > - hv_magic(hv, NULL, PERL_MAGIC_dbfile); > + gv = (GV*)SvRV(rv); > + assert(SVt_PVGV == SvTYPE(gv)); > + hv_magic(GvHVn(gv), GvAVn(gv), PERL_MAGIC_dbfile); > > > > diff -ru Enbugger-2.016-orig/lib/Enbugger.pm Enbugger-2.016/lib/Enbugger.pm > --- Enbugger-2.016-orig/lib/Enbugger.pm 2014-04-26 01:58:29.000000000 +1000 > +++ Enbugger-2.016/lib/Enbugger.pm 2014-05-15 10:51:28.000000000 +1000 > @@ -356,11 +356,11 @@ > if ( not defined $file ) { > *DB::dbline = []; > *DB::dbline = {}; > - Enbugger::set_magic_dbfile( \%DB::dbline ); > } > else { > no strict 'refs'; > *DB::dbline = \*{"main::_<$file"}; > + Enbugger::set_magic_dbfile( \*DB::dbline ); > } > } > > @@ -399,8 +399,8 @@ > > if ( ! *$glob{HASH} ) { > my %breakpoints; > - Enbugger::set_magic_dbfile(\%breakpoints); > *$glob = \%breakpoints; > + Enbugger::set_magic_dbfile($glob); > } > > $$symname ||= $file; > >