Bug #94948 for libwww-perl: Useless run-time dependency on Data::Dump

Wed Apr 23 01:12:15 2014 ppisar [...] redhat.com - Ticket created

Subject:

Useless run-time dependency on Data::Dump

6.06 META.json lists Data::Dump in prereqs{runtime}{requires}. However the module is not used anywhere. Even Changes states "Removed stray Data::Dump reference from test suite." I recommend to remove the module from the dependency list.

Wed Apr 23 01:35:19 2014 MSCHILLI [...] cpan.org - Correspondence added

On Wed Apr 23 01:12:15 2014, ppisar wrote: Show quoted text

> 6.06 META.json lists Data::Dump in prereqs{runtime}{requires}. However > the module is not used anywhere.

Actually, I've added it to the dependency list because the test suite is using it: https://github.com/libwww-perl/libwww-perl/blob/master/t/local/httpsub.t Arguably, this could be done without Data::Dump and Data::Dump be removed from the prereq list again.

Wed Apr 23 01:35:19 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 23 01:47:19 2014 MSCHILLI [...] cpan.org - Correspondence added

And done: https://github.com/libwww-perl/libwww-perl/commit/c973f0fd3554e5679e95b87c2be1f29a2d24be51 Thanks for the suggestion! -- Mike

Wed Apr 23 01:47:20 2014 MSCHILLI [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Apr 23 03:46:30 2014 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #94948] Useless run-time dependency on Data::Dump
Date:	Wed, 23 Apr 2014 09:46:13 +0200
To:	Michael_Schilli via RT <bug-libwww-perl [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Wed, Apr 23, 2014 at 01:35:19AM -0400, Michael_Schilli via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=94948 > > > On Wed Apr 23 01:12:15 2014, ppisar wrote:

> > 6.06 META.json lists Data::Dump in prereqs{runtime}{requires}. However > > the module is not used anywhere.

> > Actually, I've added it to the dependency list because the test suite is > using it: > > https://github.com/libwww-perl/libwww-perl/blob/master/t/local/httpsub.t >

The file is missing from the 6.06 release. -- Petr

Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

Wed Apr 23 13:17:38 2014 MSCHILLI [...] cpan.org - Correspondence added

On Wed Apr 23 03:46:30 2014, ppisar wrote: Show quoted text

> The file is missing from the 6.06 release.

Good catch, while it's checked into the repo, the MANIFEST file doesn't have it and therefore it's missing from the dist tarball. One more reason to remove the dependency, thanks!