Bug #94945 for B-Hooks-OP-Check-EntersubForCV: Fails with B::Utils 0.22

Tue Apr 22 23:44:57 2014 ANDK [...] cpan.org - Ticket created

CC:	JJORE [...] cpan.org
Subject:	Fails with B::Utils 0.22

As per subject. Also failing for 0.24. Have not tried 0.23. Sample fail report: http://www.cpantesters.org/cpan/report/41564858 CC'd to JJORE. HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)

Wed Apr 23 10:26:01 2014 twists [...] gmail.com - Correspondence added

CC:	"jjore [...] cpan.org" <jjore [...] cpan.org>
Subject:	Re: [rt.cpan.org #94945] Fails with B::Utils 0.22
Date:	Wed, 23 Apr 2014 07:25:50 -0700
To:	bug-B-Hooks-OP-Check-EntersubForCV [...] rt.cpan.org
From:	Joshua ben Jore <twists [...] gmail.com>

Odd. I haven't bisected to see where the issue is but I'm guessing it is https://github.com/jbenjore/B-Utils/commit/9aaf5e5b96c8bbf14f4c12bf219df24ee7ce8d49. Will look at it but I have no ability to test WRT HP-UX. It's definitely broken on my Ubuntu VM. J On Tue, Apr 22, 2014 at 8:44 PM, Andreas Koenig via RT < bug-B-Hooks-OP-Check-EntersubForCV@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=94945 > > > As per subject. Also failing for 0.24. Have not tried 0.23. > > Sample fail report: > > http://www.cpantesters.org/cpan/report/41564858 > > CC'd to JJORE. > > HTH&&Thanks, > > (Disclaimer: this was discovered by statistical analysis, I'm not speaking > as a user) >

Wed Apr 23 10:26:02 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 23 13:02:41 2014 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #94945] Fails with B::Utils 0.22
Date:	Wed, 23 Apr 2014 10:02:27 -0700
To:	Joshua ben Jore via RT <bug-B-Hooks-OP-Check-EntersubForCV [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Wed, Apr 23, 2014 at 10:26:02AM -0400, Joshua ben Jore via RT wrote: Show quoted text

> Odd. I haven't bisected to see where the issue is but I'm guessing it is > https://github.com/jbenjore/B-Utils/commit/9aaf5e5b96c8bbf14f4c12bf219df24ee7ce8d49. > Will look at it but I have no ability to test WRT HP-UX. It's definitely > broken on my Ubuntu VM.

I'd be happy to ship any fix you come up with, but I don't comprehend this code *at all*, so I'm not in a position to fix it myself. (so thanks in advance) :)

Wed Mar 25 19:56:58 2015 KENTNL [...] cpan.org - Correspondence added

On 5.20.0: B::Utils versions 0.22, 0.24 both cause failure.

Problem is not exhibited with B::Utils 0.25

( Fails always under Perl 5.21.6+ , but can't work out why yet because B::Utils itself is broken there: https://rt.cpan.org/Ticket/Display.html?id=100508 )

Wed Mar 25 19:57:46 2015 KENTNL [...] cpan.org - Requestor KENTNL added

Wed May 20 22:50:09 2015 ANDK [...] cpan.org - Correspondence added

Bisect with the current state of cpan modules leads to v5.21.3-654-ga65cc14, which leads to https://rt.perl.org/Public/Bug/Display.html?id=122857 That, in turn shows that B::Lint got patched to allow v5.21.3-654-ga65cc14. Could this be probably stretched to also fit for B-Hooks-OP-Check-EntersubForCV?

Wed Jun 03 11:22:42 2015 gregoa [...] cpan.org - Cc GREGOA added

Mon Jun 15 10:48:01 2015 contyk [...] cpan.org - Cc contyk added

Fri Jul 03 18:41:09 2015 ether [...] cpan.org - Correspondence added

On 2015-05-20 19:50:09, ANDK wrote: Show quoted text

> Bisect with the current state of cpan modules leads to v5.21.3-654- > ga65cc14, which leads to > https://rt.perl.org/Public/Bug/Display.html?id=122857 > > That, in turn shows that B::Lint got patched to allow v5.21.3-654- > ga65cc14. Could this be probably stretched to also fit for B-Hooks- > OP-Check-EntersubForCV?

I just ran into this again while testing some Sub::Call::Tail fixes on 5.23.0. Let me know how I can help.

Fri Oct 02 09:27:44 2015 gregoa [...] cpan.org - Correspondence added

Anything new here? We are about to upload Perl 5.22 to Debian/unstable soon, which means this module will have to be removed from testing first, and later from the archive completely. Any help welcome! Cheers, gregor, Debian Perl Group

Sun Dec 27 05:01:19 2015 ntyni [...] iki.fi - Correspondence added

From:

ntyni [...] iki.fi

On Wed May 20 22:50:09 2015, ANDK wrote: Show quoted text

> Bisect with the current state of cpan modules leads to v5.21.3-654- > ga65cc14, which leads to > https://rt.perl.org/Public/Bug/Display.html?id=122857 > > That, in turn shows that B::Lint got patched to allow v5.21.3-654- > ga65cc14. Could this be probably stretched to also fit for B-Hooks- > OP-Check-EntersubForCV?

Indeed. Using the B-Lint fix for inspiration, I came up with the attached patch which works for me on both 5.20 and 5.22. Hope it's correct :)

Subject:

0001-Perl-5.21.4-compatibility.patch

From 6c62adb1722a96370dbe8d294d36f9382b0788fa Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@debian.org> Date: Sun, 27 Dec 2015 11:47:24 +0200 Subject: [PATCH] Perl >= 5.21.4 compatibility This fixes test failures since perl commit v5.21.3-654-ga65cc14 . Bug: https://rt.cpan.org/Public/Bug/Display.html?id=94945 Bug-Debian: https://bugs.debian.org/787499 --- EntersubForCV.xs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/EntersubForCV.xs b/EntersubForCV.xs index 870d470..4acbcab 100644 --- a/EntersubForCV.xs +++ b/EntersubForCV.xs @@ -60,7 +60,12 @@ entersub_cb (pTHX_ OP *op, void *user_data) { return op; } - cv = GvCV (cGVOPx_gv (kid)); + GV *gv = cGVOPx_gv (kid); + if (SvROK(gv)) { /* since v5.21.3-654-ga65cc14 */ + cv = (CV *)SvRV(gv); + } else { + cv = GvCV (gv); + } if (ud->cv == cv) { op = ud->cb (aTHX_ op, cv, ud->ud); -- 2.6.4

Tue May 09 19:19:51 2017 ether [...] cpan.org - Dependency by ticket #114663 added

Tue May 09 19:20:32 2017 ether [...] cpan.org - Correspondence added

RT-Send-CC:

twists [...] gmail.com, jjore [...] cpan.org, ntyni [...] iki.fi

There is also a patch available here: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/B-Hooks-OP-Check-EntersubForCV.yml

Mon Jul 31 08:12:56 2017 ZEFRAM [...] cpan.org - Correspondence added

Fixed in B-Hooks-OP-Check-EntersubForCV-0.10, just uploaded to CPAN.

Mon Jul 31 08:13:04 2017 ZEFRAM [...] cpan.org - Status changed from 'open' to 'resolved'