Skip Menu |

This queue is for tickets about the CPAN-Meta-Check CPAN distribution.

Report information
The Basics
Id: 94925
Status: open
Priority: 0/
Queue: CPAN-Meta-Check

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc: ether [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.008
Fixed in: (no value)



Subject: documentation suggests "$types" may be an array ref, but implementation only supports scalar.

> verify_dependencies($meta, $phases, $types, $incdirs)

> Check all requirements in $meta for phases $phases and types $types

---

perl -MCPAN::Meta::Check=verify_dependencies -MCPAN::Meta -E 'verify_dependencies(CPAN::Meta->new({ version => 2 , name => q[Example] }), [q[runtime]], [q[requires]])'

requested requirements for unknown type: ARRAY(0x205b7b0) at /home/kent/perl5/perlbrew/perls/perl-5.19.11/lib/5.19.11/CPAN/Meta/Prereqs.pm line 191.

CPAN::Meta::Prereqs::merged_requirements(CPAN::Meta::Prereqs=HASH(0x23d9b38), ARRAY(0x205b6d8), ARRAY(0x2665000)) called at /home/kent/perl5/perlbrew/perls/perl-5.19.11/lib/site_perl/5.19.11/CPAN/Meta/Check.pm line 42

CPAN::Meta::Check::requirements_for(CPAN::Meta=HASH(0x205b798), ARRAY(0x205b6d8), ARRAY(0x205b7b0)) called at /home/kent/perl5/perlbrew/perls/perl-5.19.11/lib/site_perl/5.19.11/CPAN/Meta/Check.pm line 64

 CPAN::Meta::Check::verify_dependencies(CPAN::Meta=HASH(0x205b798), ARRAY(0x205b6d8), ARRAY(0x205b7b0)) called at -e line 1
---

Seems the error is this:

https://metacpan.org/source/LEONT/CPAN-Meta-Check-0.008/lib/CPAN/Meta/Check.pm#L42

       return $prereqs->merged_requirements(ref($phases) ? $phases : [ $phases ], [ $type ]);

As "$type" is already a ref, it is getting re-wrapped, and ->merged_requirements is getting passed [[qw( foo )]] instead of [qw( foo )]
 

 

On Tue Apr 22 09:15:04 2014, KENTNL wrote: Show quoted text
> > verify_dependencies($meta, $phases, $types, $incdirs)
> ------------------------------------------------------- >
> > Check all requirements in $meta for phases $phases and types $types
> > --- > > perl -MCPAN::Meta::Check=verify_dependencies -MCPAN::Meta -E > 'verify_dependencies(CPAN::Meta->new({ version => 2 , name => > q[Example] }), > [q[runtime]], [q[requires]])' > > requested requirements for unknown type: ARRAY(0x205b7b0) at > /home/kent/perl5/perlbrew/perls/perl- > 5.19.11/lib/5.19.11/CPAN/Meta/Prereqs.pm > line 191. > > CPAN::Meta::Prereqs::merged_requirements(CPAN::Meta::Prereqs=HASH(0x23d9b38), > ARRAY(0x205b6d8), ARRAY(0x2665000)) called at > /home/kent/perl5/perlbrew/perls/perl- > 5.19.11/lib/site_perl/5.19.11/CPAN/Meta/Check.pm > line 42 > > CPAN::Meta::Check::requirements_for(CPAN::Meta=HASH(0x205b798), > ARRAY(0x205b6d8), ARRAY(0x205b7b0)) called at > /home/kent/perl5/perlbrew/perls/perl- > 5.19.11/lib/site_perl/5.19.11/CPAN/Meta/Check.pm > line 64 > > CPAN::Meta::Check::verify_dependencies(CPAN::Meta=HASH(0x205b798), > ARRAY(0x205b6d8), ARRAY(0x205b7b0)) called at -e line 1 > --- > > Seems the error is this: > > https://metacpan.org/source/LEONT/CPAN-Meta-Check- > 0.008/lib/CPAN/Meta/Check.pm#L42 > > return $prereqs->merged_requirements(ref($phases) ? $phases : [ > $phases ], [ > $type ]); > > As "$type" is already a ref, it is getting re-wrapped, and > ->merged_requirements is getting passed [[qw( foo )]] instead of [qw( > foo )]
I modified the documentation for 0.009. I should probably fix the implementation instead, but there are some subtle issues (specially regarding conflicts) that I'd have to resolve first. Leon
On Fri Jun 20 20:54:44 2014, LEONT wrote: Show quoted text
> > I modified the documentation for 0.009. I should probably fix the > implementation instead, but there are some subtle issues (specially > regarding conflicts) that I'd have to resolve first. >
Kent, it's been a while on this ticket. Is the doc-fix currently on CPAN sufficient or there is more to do...?