Bug #94902 for Perl-Tidy: Configuration abbrevation parsing broken since 20120619 (w/ patch)

Mon Apr 21 02:13:50 2014 efungsh [...] gmail.com - Ticket created

CC:	efung [...] staff.iinet.net.au
Subject:	Configuration abbrevation parsing broken since 20120619 (w/ patch)
Date:	Mon, 21 Apr 2014 14:13:37 +0800
To:	bug-Perl-Tidy [...] rt.cpan.org
From:	Eric Fung <efungsh [...] gmail.com>

Hi folks, I've found that abbreviation parsing has been broken since v20120619. I've provided below what the errors are for once example. I've also attached a patch to fix the issue + a minor clarification to the abbreviation docs. While I was there, I also cleaned up the $saw_* parameter passing. Also noticed that the code was messy because of the $saw_pbp flag as the pbp specification also contains operational flags. I thought about this for a little to see if I could clean this up, but I think that --perl-best-practices should only contain flags that modify code layout so the default output modes apply. I can appreciate that may break some configurations currently out in the wild, but it just seems silly that a layout abbreviation modifies the default output behaviour of the program itself. Anyway, perhaps another discussion for another time. Cheers. ----- ericf@dev-billing-rumba1:~$ cat testrc testing1 { -pbp } testing2 { -act=2 } ericf@dev-billing-rumba1:~$ echo 'print "Hello world!\n";' > test.pl ericf@dev-billing-rumba1:~$ perl test.pl Hello world! ericf@dev-billing-rumba1:~$ perltidy -pro=testrc test.pl No '}' seen after testing1 and before testing2 in config file testrc line 3 ericf@dev-billing-rumba1:~$ perltidy --version This is perltidy, v20140328 Copyright 2000-2014, Steve Hancock Perltidy is free software and may be copied under the terms of the GNU General Public License, which is included in the distribution files. Complete documentation for perltidy can be found using 'man perltidy' or on the internet at http://perltidy.sourceforge.net. -----

Message body is not shown because sender requested not to inline it.

Mon Apr 21 02:50:33 2014 efungsh [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #94902] AutoReply: Configuration abbrevation parsing broken since 20120619 (w/ patch)
Date:	Mon, 21 Apr 2014 14:50:22 +0800
To:	bug-Perl-Tidy [...] rt.cpan.org
From:	Eric Fung <efungsh [...] gmail.com>

And of course I spot a bug in the patch file after I submit it. New version attached. On 21 April 2014 14:13, Bugs in Perl-Tidy via RT <bug-Perl-Tidy@rt.cpan.org>wrote: Show quoted text

> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Configuration abbrevation parsing broken since 20120619 (w/ > patch)", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #94902]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=94902 > > Please include the string: > > [rt.cpan.org #94902] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > bug-Perl-Tidy@rt.cpan.org > > ------------------------------------------------------------------------- > Hi folks, > > I've found that abbreviation parsing has been broken since v20120619. > > I've provided below what the errors are for once example. > I've also attached a patch to fix the issue + a minor clarification to the > abbreviation docs. > While I was there, I also cleaned up the $saw_* parameter passing. > > Also noticed that the code was messy because of the $saw_pbp flag as the > pbp specification also contains operational flags. > > I thought about this for a little to see if I could clean this up, but I > think that --perl-best-practices should only contain flags that modify code > layout so the default output modes apply. > > I can appreciate that may break some configurations currently out in the > wild, but it just seems silly that a layout abbreviation modifies the > default output behaviour of the program itself. > > Anyway, perhaps another discussion for another time. > > Cheers. > > ----- > ericf@dev-billing-rumba1:~$ cat testrc > testing1 { -pbp } > > testing2 { -act=2 } > ericf@dev-billing-rumba1:~$ echo 'print "Hello world!\n";' > test.pl > ericf@dev-billing-rumba1:~$ perl test.pl > Hello world! > ericf@dev-billing-rumba1:~$ perltidy -pro=testrc test.pl > No '}' seen after testing1 and before testing2 in config file testrc line 3 > ericf@dev-billing-rumba1:~$ perltidy --version > This is perltidy, v20140328 > > Copyright 2000-2014, Steve Hancock > > Perltidy is free software and may be copied under the terms of the GNU > General Public License, which is included in the distribution files. > > Complete documentation for perltidy can be found using 'man perltidy' > or on the internet at http://perltidy.sourceforge.net. > ----- >

Message body is not shown because sender requested not to inline it.

Mon Apr 21 09:39:23 2014 s7078hancock [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #94902] AutoReply: Configuration abbrevation parsing broken since 20120619 (w/ patch)
Date:	Mon, 21 Apr 2014 06:39:11 -0700
To:	bug-Perl-Tidy [...] rt.cpan.org
From:	Steven Hancock <s7078hancock [...] gmail.com>

Eric, Thanks for the patch. Steve On Sun, Apr 20, 2014 at 11:50 PM, Eric Fung via RT < bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text

> Queue: Perl-Tidy > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94902 > > > And of course I spot a bug in the patch file after I submit it. > > New version attached. > > > On 21 April 2014 14:13, Bugs in Perl-Tidy via RT > <bug-Perl-Tidy@rt.cpan.org>wrote: >

> > > > Greetings, > > > > This message has been automatically generated in response to the > > creation of a trouble ticket regarding: > > "Configuration abbrevation parsing broken since 20120619 (w/ > > patch)", > > a summary of which appears below. > > > > There is no need to reply to this message right now. Your ticket has

> been

> > assigned an ID of [rt.cpan.org #94902]. Your ticket is accessible > > on the web at: > > > > https://rt.cpan.org/Ticket/Display.html?id=94902 > > > > Please include the string: > > > > [rt.cpan.org #94902] > > > > in the subject line of all future correspondence about this issue. To do > > so, > > you may reply to this message. > > > > Thank you, > > bug-Perl-Tidy@rt.cpan.org > > > > ------------------------------------------------------------------------- > > Hi folks, > > > > I've found that abbreviation parsing has been broken since v20120619. > > > > I've provided below what the errors are for once example. > > I've also attached a patch to fix the issue + a minor clarification to

> the

> > abbreviation docs. > > While I was there, I also cleaned up the $saw_* parameter passing. > > > > Also noticed that the code was messy because of the $saw_pbp flag as the > > pbp specification also contains operational flags. > > > > I thought about this for a little to see if I could clean this up, but I > > think that --perl-best-practices should only contain flags that modify

> code

> > layout so the default output modes apply. > > > > I can appreciate that may break some configurations currently out in the > > wild, but it just seems silly that a layout abbreviation modifies the > > default output behaviour of the program itself. > > > > Anyway, perhaps another discussion for another time. > > > > Cheers. > > > > ----- > > ericf@dev-billing-rumba1:~$ cat testrc > > testing1 { -pbp } > > > > testing2 { -act=2 } > > ericf@dev-billing-rumba1:~$ echo 'print "Hello world!\n";' > test.pl > > ericf@dev-billing-rumba1:~$ perl test.pl > > Hello world! > > ericf@dev-billing-rumba1:~$ perltidy -pro=testrc test.pl > > No '}' seen after testing1 and before testing2 in config file testrc

> line 3

> > ericf@dev-billing-rumba1:~$ perltidy --version > > This is perltidy, v20140328 > > > > Copyright 2000-2014, Steve Hancock > > > > Perltidy is free software and may be copied under the terms of the GNU > > General Public License, which is included in the distribution files. > > > > Complete documentation for perltidy can be found using 'man perltidy' > > or on the internet at http://perltidy.sourceforge.net. > > ----- > >

> >

Mon Apr 21 09:39:23 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 21 22:37:13 2014 efungsh [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #94902] AutoReply: Configuration abbrevation parsing broken since 20120619 (w/ patch)
Date:	Tue, 22 Apr 2014 10:37:00 +0800
To:	bug-Perl-Tidy [...] rt.cpan.org
From:	Eric Fung <efungsh [...] gmail.com>

No problems, though one of my colleagues picked up a grammar error in my documentation update (it's vs its). Thought I double checked that but looks like I didn't. Attached another full version of the patch with that fixed. Cheers, Eric On 21 April 2014 21:39, Steven Hancock via RT <bug-Perl-Tidy@rt.cpan.org>wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=94902 > > > Eric, > Thanks for the patch. > Steve > > > On Sun, Apr 20, 2014 at 11:50 PM, Eric Fung via RT < > bug-Perl-Tidy@rt.cpan.org> wrote: >

> > Queue: Perl-Tidy > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94902 > > > > > And of course I spot a bug in the patch file after I submit it. > > > > New version attached. > > > > > > On 21 April 2014 14:13, Bugs in Perl-Tidy via RT > > <bug-Perl-Tidy@rt.cpan.org>wrote: > >

> > > > > > Greetings, > > > > > > This message has been automatically generated in response to the > > > creation of a trouble ticket regarding: > > > "Configuration abbrevation parsing broken since 20120619 (w/ > > > patch)", > > > a summary of which appears below. > > > > > > There is no need to reply to this message right now. Your ticket has

> > been

> > > assigned an ID of [rt.cpan.org #94902]. Your ticket is accessible > > > on the web at: > > > > > > https://rt.cpan.org/Ticket/Display.html?id=94902 > > > > > > Please include the string: > > > > > > [rt.cpan.org #94902] > > > > > > in the subject line of all future correspondence about this issue. To

> do

> > > so, > > > you may reply to this message. > > > > > > Thank you, > > > bug-Perl-Tidy@rt.cpan.org > > > > > >

> -------------------------------------------------------------------------

> > > Hi folks, > > > > > > I've found that abbreviation parsing has been broken since v20120619. > > > > > > I've provided below what the errors are for once example. > > > I've also attached a patch to fix the issue + a minor clarification to

> > the

> > > abbreviation docs. > > > While I was there, I also cleaned up the $saw_* parameter passing. > > > > > > Also noticed that the code was messy because of the $saw_pbp flag as

> the

> > > pbp specification also contains operational flags. > > > > > > I thought about this for a little to see if I could clean this up, but

> I

> > > think that --perl-best-practices should only contain flags that modify

> > code

> > > layout so the default output modes apply. > > > > > > I can appreciate that may break some configurations currently out in

> the

> > > wild, but it just seems silly that a layout abbreviation modifies the > > > default output behaviour of the program itself. > > > > > > Anyway, perhaps another discussion for another time. > > > > > > Cheers. > > > > > > ----- > > > ericf@dev-billing-rumba1:~$ cat testrc > > > testing1 { -pbp } > > > > > > testing2 { -act=2 } > > > ericf@dev-billing-rumba1:~$ echo 'print "Hello world!\n";' > test.pl > > > ericf@dev-billing-rumba1:~$ perl test.pl > > > Hello world! > > > ericf@dev-billing-rumba1:~$ perltidy -pro=testrc test.pl > > > No '}' seen after testing1 and before testing2 in config file testrc

> > line 3

> > > ericf@dev-billing-rumba1:~$ perltidy --version > > > This is perltidy, v20140328 > > > > > > Copyright 2000-2014, Steve Hancock > > > > > > Perltidy is free software and may be copied under the terms of the GNU > > > General Public License, which is included in the distribution files. > > > > > > Complete documentation for perltidy can be found using 'man perltidy' > > > or on the internet at http://perltidy.sourceforge.net. > > > ----- > > >

> > > >

> >

Message body is not shown because sender requested not to inline it.

Fri Jul 11 08:51:10 2014 perltidy [...] users.sourceforge.net - Correspondence added

Version 20140711 fixes this problem, thanks for the patch.

Fri Jul 11 08:51:11 2014 perltidy [...] users.sourceforge.net - Status changed from 'open' to 'resolved'