Skip Menu |

This queue is for tickets about the Search-GIN CPAN distribution.

Report information
The Basics
Id: 94858
Status: resolved
Priority: 0/
Queue: Search-GIN

People
Owner: ether [...] cpan.org
Requestors: ROBN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.09



Subject: [PATCH] Fix arg unpacking in Query::Manual::consistent
"consistent" is supposed to take three args. "Query::Manual::consistent" doesn't, so the provided filter function receives the database handle instead of the object itself, making the whole thing rather useless! (First submitted at https://github.com/ruoso/search-gin/pull/2. Do you prefer patches via Github or here?)
Subject: fix-arg-unpacking.patch
diff --git a/lib/Search/GIN/Query/Manual.pm b/lib/Search/GIN/Query/Manual.pm index 097a1f9..f9eb65a 100644 --- a/lib/Search/GIN/Query/Manual.pm +++ b/lib/Search/GIN/Query/Manual.pm @@ -49,7 +49,7 @@ sub extract_values { } sub consistent { - my ( $self, $obj ) = @_; + my ( $self, $index, $obj ) = @_; if ( my $filter = $self->filter ) { return $obj->$filter;
So, anyone alive reading this? Otherwise I start to hassle people for co-maint directly :)
Subject: Re: [rt.cpan.org #94858] [PATCH] Fix arg unpacking in Query::Manual::consistent
Date: Mon, 14 Jul 2014 07:09:20 -0700
To: Robert Norris via RT <bug-Search-GIN [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Mon, Jul 14, 2014 at 02:40:31AM -0400, Robert Norris via RT wrote: Show quoted text
> Queue: Search-GIN > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94858 > > > So, anyone alive reading this? Otherwise I start to hassle people for co-maint directly :)
*staggers towards the light* mmm, me smell BRAAAAINS
Good you sent that poke; you would have been waiting for years :D 0.09 is released!
On Mon Jul 14 20:11:18 2014, ETHER wrote: Show quoted text
> Good you sent that poke; you would have been waiting for years :D
Good that it worked! Some of my tickets have been waiting for years! Show quoted text
> 0.09 is released!
Wonderful! And you are now on my list of people to purchase beverages for before I die. Thanks!