Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 94841
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: greg [...] turnstep.com
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.1.1
Fixed in: 3.2.0



Subject: tests fail on Windows
PostgreSQL is running. Windows XP Russian. Configuring DBD::Pg 3.1.1 PostgreSQL version: 80401 (default port: 5432) POSTGRES_HOME: (not set) POSTGRES_INCLUDE: C:/STRAWB~1/c/include POSTGRES_LIB: C:/STRAWB~1/c/lib OS: MSWin32 Using DBI 1.623 (for perl 5.014000 on MSWin32-x86-multi-thread) installed in C:/strawberry514/perl/site/lib/auto/DBI/ Generating a dmake-style Makefile Writing Makefile for DBD::Pg Writing MYMETA.yml and MYMETA.json Skip blib\lib/Bundle/DBD/Pg.pm (unchanged) Skip blib\lib\DBD/Pg.pm (unchanged) gcc -c -I"C:/STRAWB~1/c/include" -IC:\strawberry514\perl\site\lib\auto\DBI -s -O2 -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=80401 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.1.1\" -DXS_VERSION=\"3.1.1\" "-IC:\strawberry514\perl\lib\CORE" Pg.c gcc -c -I"C:/STRAWB~1/c/include" -IC:\strawberry514\perl\site\lib\auto\DBI -s -O2 -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=80401 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.1.1\" -DXS_VERSION=\"3.1.1\" "-IC:\strawberry514\perl\lib\CORE" dbdimp.c gcc -c -I"C:/STRAWB~1/c/include" -IC:\strawberry514\perl\site\lib\auto\DBI -s -O2 -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=80401 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.1.1\" -DXS_VERSION=\"3.1.1\" "-IC:\strawberry514\perl\lib\CORE" quote.c gcc -c -I"C:/STRAWB~1/c/include" -IC:\strawberry514\perl\site\lib\auto\DBI -s -O2 -DWIN32 -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=80401 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.1.1\" -DXS_VERSION=\"3.1.1\" "-IC:\strawberry514\perl\lib\CORE" types.c Running Mkbootstrap for DBD::Pg () C:\strawberry514\perl\bin\perl.exe -MExtUtils::Command -e chmod -- 644 Pg.bs dlltool --def Pg.def --output-exp dll.exp g++ -o blib\arch\auto\DBD\Pg\Pg.dll -Wl,--base-file -Wl,dll.base -mdll -s -L"C:\strawberry514\perl\lib\CORE" -L"C:\strawberry514\c\lib" Pg.o dbdimp.o quote.o types.o C:\strawberry514\perl\lib\CORE\libperl514.a C:\STRAWB~1\c\lib\libpq.a C:\strawberry514\c\i686-w64-mingw32\lib\libm.a C:\strawberry514\c\i686-w64-mingw32\lib\libsecur32.a C:\strawberry514\c\i686-w64-mingw32\lib\libmoldname.a C:\strawberry514\c\i686-w64-mingw32\lib\libkernel32.a C:\strawberry514\c\i686-w64-mingw32\lib\libuser32.a C:\strawberry514\c\i686-w64-mingw32\lib\libgdi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libwinspool.a C:\strawberry514\c\i686-w64-mingw32\lib\libcomdlg32.a C:\strawberry514\c\i686-w64-mingw32\lib\libadvapi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libshell32.a C:\strawberry514\c\i686-w64-mingw32\lib\libole32.a C:\strawberry514\c\i686-w64-mingw32\lib\liboleaut32.a C:\strawberry514\c\i686-w64-mingw32\lib\libnetapi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libuuid.a C:\strawberry514\c\i686-w64-mingw32\lib\libws2_32.a C:\strawberry514\c\i686-w64-mingw32\lib\libmpr.a C:\strawberry514\c\i686-w64-mingw32\lib\libwinmm.a C:\strawberry514\c\i686-w64-mingw32\lib\libversion.a C:\strawberry514\c\i686-w64-mingw32\lib\libodbc32.a C:\strawberry514\c\i686-w64-mingw32\lib\libodbccp32.a C:\strawberry514\c\i686-w64-mingw32\lib\libcomctl32.a dll.exp dlltool --def Pg.def --base-file dll.base --output-exp dll.exp g++ -o blib\arch\auto\DBD\Pg\Pg.dll -mdll -s -L"C:\strawberry514\perl\lib\CORE" -L"C:\strawberry514\c\lib" Pg.o dbdimp.o quote.o types.o C:\strawberry514\perl\lib\CORE\libperl514.a C:\STRAWB~1\c\lib\libpq.a C:\strawberry514\c\i686-w64-mingw32\lib\libm.a C:\strawberry514\c\i686-w64-mingw32\lib\libsecur32.a C:\strawberry514\c\i686-w64-mingw32\lib\libmoldname.a C:\strawberry514\c\i686-w64-mingw32\lib\libkernel32.a C:\strawberry514\c\i686-w64-mingw32\lib\libuser32.a C:\strawberry514\c\i686-w64-mingw32\lib\libgdi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libwinspool.a C:\strawberry514\c\i686-w64-mingw32\lib\libcomdlg32.a C:\strawberry514\c\i686-w64-mingw32\lib\libadvapi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libshell32.a C:\strawberry514\c\i686-w64-mingw32\lib\libole32.a C:\strawberry514\c\i686-w64-mingw32\lib\liboleaut32.a C:\strawberry514\c\i686-w64-mingw32\lib\libnetapi32.a C:\strawberry514\c\i686-w64-mingw32\lib\libuuid.a C:\strawberry514\c\i686-w64-mingw32\lib\libws2_32.a C:\strawberry514\c\i686-w64-mingw32\lib\libmpr.a C:\strawberry514\c\i686-w64-mingw32\lib\libwinmm.a C:\strawberry514\c\i686-w64-mingw32\lib\libversion.a C:\strawberry514\c\i686-w64-mingw32\lib\libodbc32.a C:\strawberry514\c\i686-w64-mingw32\lib\libodbccp32.a C:\strawberry514\c\i686-w64-mingw32\lib\libcomctl32.a dll.exp C:\strawberry514\perl\bin\perl.exe -MExtUtils::Command -e chmod -- 755 blib\arch\auto\DBD\Pg\Pg.dll C:\strawberry514\perl\bin\perl.exe -MExtUtils::Command -e cp -- Pg.bs blib\arch\auto\DBD\Pg\Pg.bs C:\strawberry514\perl\bin\perl.exe -MExtUtils::Command -e chmod -- 644 blib\arch\auto\DBD\Pg\Pg.bs C:\strawberry514\perl\bin\perl.exe "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/00_signature.t .... skipped: Set the environment variable TEST_SIGNATURE to enable this test t/00basic.t ......... ok # # DBI Version 1.623 # DBD::Pg Version 3.1.1 # Perl Version 5.14.0 # OS MSWin32 # PostgreSQL (compiled) 80401 # PostgreSQL (target) 90103 # PostgreSQL (reported) PostgreSQL 9.1.3, compiled by Visual C++ build 1500, 32-bit # Default port 5432 # DBI_DSN dbi:Pg:host=localhost # DBI_USER postgres # Test schema dbd_pg_testschema # array_nulls on # backslash_quote safe_encoding # client_encoding UTF8 # server_encoding UTF8 # standard_conforming_strings on # Adjusted: DBI_DSN t/01connect.t ....... ok t/01constants.t ..... ok # Looks like you planned 260 tests but ran 259. t/02attribs.t ....... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/260 subtests (less 16 skipped subtests: 243 okay) t/03dbmethod.t ...... ok Your vendor has not defined POSIX macro SIGALRM, used at t/03smethod.t line 733 Issuing rollback() due to DESTROY without explicit disconnect() of DBD::Pg::db handle host=localhost at C:/strawberry514/perl/lib/POSIX.pm line 47. Issuing rollback() due to DESTROY without explicit disconnect() of DBD::Pg::db handle host=localhost at C:/strawberry514/perl/lib/POSIX.pm line 47. # Looks like you planned 122 tests but ran 121. # Looks like your test exited with 2 just after 121. t/03smethod.t ....... Dubious, test returned 2 (wstat 512, 0x200) Failed 1/122 subtests (less 2 skipped subtests: 119 okay) NOTICE: RAISE NOTICE FROM dbdpg_test_error_handler WARNING: RAISE WARNING FROM dbdpg_test_error_handler # Checking pg_st_split_statement. This may take a while... Error removing C:\strawberry514\cpan\build\DBD-Pg-3.1.1-w_s622\dbdpg_test_IkCXLstst at C:/strawberry514/perl/site/lib/File/Temp.pm line 761. t/04misc.t .......... ok t/06bytea.t ......... ok t/07copy.t .......... ok t/08async.t ......... ok t/09arrays.t ........ ok t/12placeholders.t .. ok t/20savepoints.t .... ok t/30unicode.t ....... ok Removing test database directory t/99cleanup.t ....... ok Test Summary Report ------------------- t/02attribs.t (Wstat: 65280 Tests: 259 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 260 tests but ran 259. t/03smethod.t (Wstat: 512 Tests: 121 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 122 tests but ran 121. Files=16, Tests=1768, 43 wallclock secs ( 0.34 usr + 0.08 sys = 0.42 CPU) Result: FAIL Failed 2/16 test programs. 0/1768 subtests failed. dmake.EXE: Error code 255, while making 'test_dynamic' -- Alexandr Ciornii, http://chorny.net
Thanks for the report, we'll look into it. Seems like we need to confirm the availability of a working SIGALRM for that test.
Made some changes to fix the two problems seen - a better skip count in 02attribs.t, and skipping the entire POSIX cancel test if we are Windows in 03smethod.t. Please give it a shot if you can and see it things are working better. Git commits are b01d54377ab3c9db5bc4d108728b5e1b99d384e5 and 7e3b9e74ab10821a3c9977c7cf83dc33646fe2dd git clone https://github.com/bucardo/dbdpg.git

Message body is not shown because it is too large.

Show quoted text
> but 02attribs.t still has problems
Thanks for the quick reply. Looks like there was another skip counting error. Fixed in ec2abc3c7f552f5767a299b8c4f0e6174928ff7a
On Fri Apr 18 15:53:16 2014, TURNSTEP wrote: Show quoted text
> > but 02attribs.t still has problems
> > Thanks for the quick reply. Looks like there was another skip counting > error. Fixed in ec2abc3c7f552f5767a299b8c4f0e6174928ff7a
Now all tests pass. -- Alexandr Ciornii, http://chorny.net