Skip Menu |

This queue is for tickets about the Digest-SHA CPAN distribution.

Report information
The Basics
Id: 94830
Status: resolved
Priority: 0/
Queue: Digest-SHA
People
Owner: mshelor [...] cpan.org
Requestors: nomad [...] null.net
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 5.89

History Show all quoted text
  Thu Apr 17 07:02:34 2014 nomad [...] null.net - Ticket created
Subject: Inheritance broke in 5.87
Date: Thu, 17 Apr 2014 13:02:17 +0200
To: bug-Digest-SHA [...] rt.cpan.org
From: Mark Lawrence <nomad [...] null.net>
Up until 5.87 it was possible to inherit from Digest::SHA. Since that release however the [hex|b64]digest() methods return undef. Test case attached. -- Mark Lawrence

Message body is not shown because sender requested not to inline it.

  Thu Apr 17 07:09:35 2014 nomad [...] null.net - Correspondence added
Subject: Re: [rt.cpan.org #94830] AutoReply: Inheritance broke in 5.87
Date: Thu, 17 Apr 2014 13:09:20 +0200
To: Bugs in Digest-SHA via RT <bug-Digest-SHA [...] rt.cpan.org>
From: Mark Lawrence <nomad [...] null.net>
Show quoted text
> Test case attached.
That wasn't a very good one, style-wise. A better one is attached. -- Mark Lawrence

Message body is not shown because sender requested not to inline it.

  Thu Apr 17 20:27:51 2014 mshelor [...] cpan.org - Taken
  Thu Apr 17 20:36:57 2014 mshelor [...] cpan.org - Correspondence added
Indeed. Thanks for catching and reporting this. sv_isa() wasn't the appropriate macro to use: too restrictive. I've modified SHA.xs to use a combination of sv_isobject() and sv_derived_from() instead, which appears to work just fine. Will be released in the next version (5.89). Mark
  Thu Apr 17 20:36:58 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 20 00:02:07 2014 mshelor [...] cpan.org - Correspondence added
RT-Send-CC: nomad [...] null.net
Fixed in 5.89. A bit of wrangling was needed to keep things working in 5.003, which has no 'sv_derived_from'. This was quick work using code from 5.004. Acknowledgments to Graham Barr for his tidy implementation.
  Sun Apr 20 00:02:08 2014 mshelor [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Apr 20 00:02:09 2014 mshelor [...] cpan.org - Fixed in 5.89 added
  Sun Apr 20 13:04:50 2014 nomad [...] null.net - Correspondence added
Subject: Re: [rt.cpan.org #94830] Inheritance broke in 5.87
Date: Sun, 20 Apr 2014 19:04:39 +0200
To: Mark Shelor via RT <bug-Digest-SHA [...] rt.cpan.org>
From: Mark Lawrence <nomad [...] null.net>
Show quoted text
> Fixed in 5.89.
Thanks for the quick response, and for the effort you put into the package(s) in general. -- Mark Lawrence