Skip Menu |

This queue is for tickets about the Scalar-List-Utils CPAN distribution.

Report information
The Basics
Id: 94806
Status: resolved
Priority: 0/
Queue: Scalar-List-Utils
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.39

History Show all quoted text
  Wed Apr 16 15:11:24 2014 ether [...] cpan.org - Ticket created
Subject: looks_like_number exposes internal details inappropriately
It should instead return a boolean. see https://rt.cpan.org/Ticket/Display.html?id=94805
  Wed Apr 16 15:11:45 2014 ether [...] cpan.org - Reference to ticket #94805 added
  Thu Jun 05 10:28:25 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added
On Wed Apr 16 15:11:24 2014, ETHER wrote: Show quoted text
> It should instead return a boolean. see > https://rt.cpan.org/Ticket/Display.html?id=94805
Seems good. -- Paul Evans
Subject: rt94806.patch
diff --git a/ListUtil.xs b/ListUtil.xs index 5d66ee0..84be2f1 100644 --- a/ListUtil.xs +++ b/ListUtil.xs @@ -1076,13 +1076,13 @@ CODE: } #if PERL_BCDVERSION < 0x5008005 if(SvPOK(sv) || SvPOKp(sv)) { - RETVAL = looks_like_number(sv); + RETVAL = !!looks_like_number(sv); } else { RETVAL = SvFLAGS(sv) & (SVf_NOK|SVp_NOK|SVf_IOK|SVp_IOK); } #else - RETVAL = looks_like_number(sv); + RETVAL = !!looks_like_number(sv); #endif OUTPUT: RETVAL
  Thu Jun 05 10:28:25 2014 The RT System itself - Status changed from 'new' to 'open'
  Thu Jun 05 10:28:26 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'
  Fri Jun 06 06:48:36 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Released in 1.39 -- Paul Evans
  Fri Jun 06 06:48:39 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'
  Fri Jun 06 06:48:39 2014 leonerd-cpan [...] leonerd.org.uk - Fixed in 1.39 added