Bug #94782 for Prima: (MSWin32) Handle correctly situation when $Config{dlext} is not equal to 'dll'

Tue Apr 15 17:42:23 2014 kmx [...] cpan.org - Ticket created

Subject:

(MSWin32) Handle correctly situation when $Config{dlext} is not equal to 'dll'

Hi,

in the coming strawberry perl 5.20.x series I am gonna switch $Config{dlext} to 'xs.dll' which unfortunately breaks Prima.

Please consider the following patch

--- Prima-1.38_orig/Makefile.PL 2014-01-02 14:06:50.000000000 +0100
+++ Prima-1.38/Makefile.PL      2014-04-15 23:29:32.126336100 +0200
@@ -1816,7 +1816,7 @@
                cleanup("Error copying $_ to $_") unless copy $_, $f;
        }
        if ($^O eq 'cygwin') {
-               system "strip $DISTNAME/auto/Prima/Prima.dll" ; # it's 27 MB!
+               system "strip $DISTNAME/auto/Prima/Prima.$Config{dlext}" ; # it's 27 MB!
                if ( $] > 5.010 ) {
                        $cygwin_fake_Slib = 'SlibPrima' . ( $Config{lib_ext} || '.a' );
                        open F, '>', "$DISTNAME/auto/Prima/$cygwin_fake_Slib";
@@ -1976,7 +1976,7 @@
        my $t = $self->SUPER::dynamic_lib(@_);
        if ( $win32_use_dlltool ) {
                my $lib  = qd("blib/arch/auto/Prima/${LIB_PREFIX}Prima$LIB_EXT");
-               my $line = "\t$win32_use_dlltool -l $lib -d Prima.def -D PRIMA.DLL \$\@\n";
+               my $line = "\t$win32_use_dlltool -l $lib -d Prima.def -D PRIMA.$Config{dlext} \$\@\n";
                $END .= <<BAD_MAKEFILE unless $t =~ s/(^\$\(INST_DYNAMIC\)\:.*?\n(?:\t.*?\n)*)/$1$line/m;

Wed Apr 16 01:35:31 2014 KARASIK [...] cpan.org - Correspondence added

Thank you, applied!

Wed Apr 16 01:35:31 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 16 01:35:33 2014 KARASIK [...] cpan.org - Status changed from 'open' to 'resolved'

Mon May 19 18:07:30 2014 kmx [...] cpan.org - Correspondence added

Please consider making release with this patch as 5.20.0 release is pretty close and I am going to release strawberry perl shortly after that. The Prima users using strawberry perl 5.20 might be in a trouble.

Thanks.

--
kmx

Wed May 21 16:15:27 2014 KARASIK [...] cpan.org - Correspondence added

Thanks for heads up! Is there somewhere a binary for 5.20-RC1 so I can test it before?

Wed May 21 16:50:49 2014 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #94782] (MSWin32) Handle correctly situation when $Config{dlext} is not equal to 'dll'
Date:	Wed, 21 May 2014 22:50:27 +0200
To:	bug-Prima [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

5.20.0-RC1 will be available in 1-2 hours at http://strawberryperl.com/beta

Thu May 22 07:56:22 2014 KARASIK [...] cpan.org - Correspondence added

1.39 is released and compiles on 5.20-RC1 fine, thank you!