Bug #94717 for Imager: libpng 1.6.10 CRC "benign error" behavior change results in failing test

Mon Apr 14 08:35:22 2014 BWISTI [...] cpan.org - Ticket created

Subject:

libpng 1.6.10 CRC "benign error" behavior change results in failing test

I have libpng 1.6.10 installed on OS X via MacPorts and Perl 5.18.1 installed via Perlbrew. Installing Imager-0.98 or a fresh git checkout of Imager results in an error during `make test`: ~~~~~ PERL_DL_NONLAZY=1 /Users/brian/perl5/perlbrew/perls/perl-5.18.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, '../blib/lib', '../blib/arch')" t/*.t t/00load.t .. ok t/10png.t ... 1/249 # Library version 10610 # Failed test 'read bad crc with png_ignore_benign_errors' # at t/10png.t line 188. # Looks like you failed 1 test of 249. t/10png.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/249 subtests Test Summary Report ------------------- t/10png.t (Wstat: 256 Tests: 249 Failed: 1) Failed test: 39 Non-zero exit status: 1 Files=2, Tests=250, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.56 cusr 0.14 csys = 0.76 CPU) Result: FAIL Failed 1/2 test programs. 1/250 subtests failed. ~~~~~ The libpng home page <http://www.libpng.org/pub/png/libpng.html> specifically mentions change in the treatment of CRC as benign errors: "libpng 1.6.10 ... also fixes a bug in which libpng would read invalid sBIT chunks and another in which CRC errors were treated as benign." Skipping this test and bumping the version number to satisfy xt/x90cmpversion.t resulted in all tests passing. I would add a patch, but I'm not sure what the desired test would be given libpng's change in behavior.

Wed Apr 23 01:31:55 2014 TONYC [...] cpan.org - Correspondence added

On Mon Apr 14 08:35:22 2014, BWISTI wrote: Show quoted text

> I have libpng 1.6.10 installed on OS X via MacPorts and Perl 5.18.1 > installed via Perlbrew. Installing Imager-0.98 or a fresh git checkout > of Imager results in an error during `make test`: > > ~~~~~ > PERL_DL_NONLAZY=1 /Users/brian/perl5/perlbrew/perls/perl- > 5.18.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, > '../blib/lib', '../blib/arch')" t/*.t > t/00load.t .. ok > t/10png.t ... 1/249 # Library version 10610 > > # Failed test 'read bad crc with png_ignore_benign_errors' > # at t/10png.t line 188. > # Looks like you failed 1 test of 249. > t/10png.t ... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/249 subtests > > Test Summary Report > ------------------- > t/10png.t (Wstat: 256 Tests: 249 Failed: 1) > Failed test: 39 > Non-zero exit status: 1 > Files=2, Tests=250, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.56 > cusr 0.14 csys = 0.76 CPU) > Result: FAIL > Failed 1/2 test programs. 1/250 subtests failed. > ~~~~~ > > The libpng home page <http://www.libpng.org/pub/png/libpng.html> > specifically mentions change in the treatment of CRC as benign errors: > "libpng 1.6.10 ... also fixes a bug in which libpng would read invalid > sBIT chunks and another in which CRC errors were treated as benign." > > Skipping this test and bumping the version number to satisfy > xt/x90cmpversion.t resulted in all tests passing. I would add a patch, > but I'm not sure what the desired test would be given libpng's change > in behavior.

Thanks, I'll fix this for the next release. I plan on the following behavior: - restore the original test that checked that CRC errors caused a read failure - skip that test for libpng 1.6.0 - 1.6.9 - add a test that tests the benign errors check with some other PNG badness Tony

Wed Apr 23 01:31:56 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 05 04:24:41 2014 jquelin [...] cpan.org - Cc JQUELIN added

Fri Jun 13 06:51:51 2014 TONYC [...] cpan.org - Status changed from 'open' to 'patched'

Mon Aug 25 01:28:11 2014 TONYC [...] cpan.org - Correspondence added

On Mon Apr 14 08:35:22 2014, BWISTI wrote: Show quoted text

> I have libpng 1.6.10 installed on OS X via MacPorts and Perl 5.18.1 > installed via Perlbrew. Installing Imager-0.98 or a fresh git checkout > of Imager results in an error during `make test`:

Thanks, fixed in Imager 0.99. Tony

Mon Aug 25 01:28:12 2014 TONYC [...] cpan.org - Status changed from 'patched' to 'resolved'