Bug #94487 for SHARYANTO-Number-Util: Tests fail with bleadperl

Sun Apr 06 16:09:41 2014 SREZIC [...] cpan.org - Ticket created

Subject:

Tests fail with bleadperl

Just FYI... tests fail with latest perls for some locales, e.g. German locales. Regards, Slaven

Sun Apr 06 16:57:28 2014 stevenharyanto [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #94487] Tests fail with bleadperl
Date:	Mon, 7 Apr 2014 03:57:15 +0700
To:	bug-SHARYANTO-Number-Util [...] rt.cpan.org
From:	Steven Haryanto <stevenharyanto [...] gmail.com>

Hi Slaven, CPANTesters.org says there are 5 fail reports, but I can't seem to get the actual error reports. http://www.cpantesters.org/distro/S/SHARYANTO-Number-Util.html?oncpan=1&distmat=1&version=0.56&grade=3 Any pointers? Regards, Steven On Mon, Apr 7, 2014 at 3:09 AM, Slaven_Rezic via RT < bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: Show quoted text

> Sun Apr 06 16:09:41 2014: Request 94487 was acted upon. > Transaction: Ticket created by SREZIC > Queue: SHARYANTO-Number-Util > Subject: Tests fail with bleadperl > Broken in: 0.56 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > Just FYI... tests fail with latest perls for some locales, e.g. German > locales. > > Regards, > Slaven >

Sun Apr 06 16:57:28 2014 The RT System itself - Status changed from 'new' to 'open'

Sun Apr 06 17:08:06 2014 slaven [...] rezic.de - Correspondence added

CC:	SREZIC [...] cpan.org
Subject:	Re: [rt.cpan.org #94487] Tests fail with bleadperl
Date:	Sun, 06 Apr 2014 23:07:04 +0200
To:	bug-SHARYANTO-Number-Util [...] rt.cpan.org
From:	Slaven Rezic <slaven [...] rezic.de>

"Steven Haryanto via RT" <bug-SHARYANTO-Number-Util@rt.cpan.org> writes: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > Hi Slaven, > > CPANTesters.org says there are 5 fail reports, but I can't seem to get the > actual error reports. > > http://www.cpantesters.org/distro/S/SHARYANTO-Number-Util.html?oncpan=1&distmat=1&version=0.56&grade=3 > > Any pointers?

Hi Steven, I don't know what's wrong here. You can go to the matrix instead to see the overview and click into the fail reports: http://matrix.cpantesters.org/?dist=SHARYANTO-Number-Util+0.56 You can access the matrix via the "grid" symbol on metacpan.org, or via the "Perl/Platform Version Matrix" link on search.cpan.org. A quick look into your code shows the following: - The module is using "use locale". I am not sure if you really want this. Note also that "use locale" is effective for the LC_NUMERIC locale since 5.19.9 or so. This means printf with a "%f" specifier under a German locale will use a dot for earlier perl versions, and a comma for future perl versions. - You try to protect yourself using $ENV{LANG}="C" in the test. This works only if the user sets only LANG. But the LC_ALL or LC_NUMERIC environment variables are "stronger" than LANG. Best is to set LC_ALL, at least for Linux and FreeBSD. Regards, Slaven Show quoted text

> > Regards, > Steven > > > On Mon, Apr 7, 2014 at 3:09 AM, Slaven_Rezic via RT < > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: >

>> Sun Apr 06 16:09:41 2014: Request 94487 was acted upon. >> Transaction: Ticket created by SREZIC >> Queue: SHARYANTO-Number-Util >> Subject: Tests fail with bleadperl >> Broken in: 0.56 >> Severity: (no value) >> Owner: Nobody >> Requestors: SREZIC@cpan.org >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > >> >> >> Just FYI... tests fail with latest perls for some locales, e.g. German >> locales. >> >> Regards, >> Slaven >>

-- Slaven Rezic - slaven <at> rezic <dot> de Berlin Perl Mongers - http://berlin.pm.org

Sun Apr 06 17:24:53 2014 stevenharyanto [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #94487] Tests fail with bleadperl
Date:	Mon, 7 Apr 2014 04:24:40 +0700
To:	bug-SHARYANTO-Number-Util [...] rt.cpan.org
From:	Steven Haryanto <stevenharyanto [...] gmail.com>

Hi Slaven, I do have to "use locale" to produce a comma for German or Indonesian locale. Otherwise perl will still use C locale. Haven't tried 5.19.9+ though (am compiling 5.19.10 with perlbrew as I am writing this). Changed LANG to LC_ALL. Thanks. Regards, Steven On Mon, Apr 7, 2014 at 4:08 AM, slaven@rezic.de via RT < bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: Show quoted text

> Queue: SHARYANTO-Number-Util > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > "Steven Haryanto via RT" <bug-SHARYANTO-Number-Util@rt.cpan.org> writes: >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > > Hi Slaven, > > > > CPANTesters.org says there are 5 fail reports, but I can't seem to get

> the

> > actual error reports. > > > >

> http://www.cpantesters.org/distro/S/SHARYANTO-Number-Util.html?oncpan=1&distmat=1&version=0.56&grade=3

> > > > Any pointers?

> > Hi Steven, > > I don't know what's wrong here. You can go to the matrix instead to see > the overview and click into the fail reports: > http://matrix.cpantesters.org/?dist=SHARYANTO-Number-Util+0.56 > > You can access the matrix via the "grid" symbol on metacpan.org, or via > the "Perl/Platform Version Matrix" link on search.cpan.org. > > A quick look into your code shows the following: > > - The module is using "use locale". I am not sure if you really want > this. Note also that "use locale" is effective for the LC_NUMERIC > locale since 5.19.9 or so. This means printf with a "%f" specifier > under a German locale will use a dot for earlier perl versions, and a > comma for future perl versions. > > - You try to protect yourself using $ENV{LANG}="C" in the test. This > works only if the user sets only LANG. But the LC_ALL or LC_NUMERIC > environment variables are "stronger" than LANG. Best is to set LC_ALL, > at least for Linux and FreeBSD. > > Regards, > Slaven >

> > > > Regards, > > Steven > > > > > > On Mon, Apr 7, 2014 at 3:09 AM, Slaven_Rezic via RT < > > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: > >

> >> Sun Apr 06 16:09:41 2014: Request 94487 was acted upon. > >> Transaction: Ticket created by SREZIC > >> Queue: SHARYANTO-Number-Util > >> Subject: Tests fail with bleadperl > >> Broken in: 0.56 > >> Severity: (no value) > >> Owner: Nobody > >> Requestors: SREZIC@cpan.org > >> Status: new > >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > >> > >> > >> Just FYI... tests fail with latest perls for some locales, e.g. German > >> locales. > >> > >> Regards, > >> Slaven > >>

> >

> > -- > Slaven Rezic - slaven <at> rezic <dot> de > > Berlin Perl Mongers - http://berlin.pm.org > >

Mon Apr 28 00:35:52 2014 sharyanto [...] cpan.org - Correspondence added

I'm not seeing any more failure reports, so closing ticket. Regards, Steven On Sun Apr 06 17:24:53 2014, stevenharyanto@gmail.com wrote: Show quoted text

> Hi Slaven, > > I do have to "use locale" to produce a comma for German or Indonesian > locale. Otherwise perl will still use C locale. Haven't tried 5.19.9+ > though (am compiling 5.19.10 with perlbrew as I am writing this). > > Changed LANG to LC_ALL. Thanks. > > Regards, > Steven > > > On Mon, Apr 7, 2014 at 4:08 AM, slaven@rezic.de via RT < > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: >

> > Queue: SHARYANTO-Number-Util > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > > "Steven Haryanto via RT" <bug-SHARYANTO-Number-Util@rt.cpan.org> > > writes: > >

> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > > > > Hi Slaven, > > > > > > CPANTesters.org says there are 5 fail reports, but I can't seem to > > > get

> > the

> > > actual error reports. > > > > > >

> > http://www.cpantesters.org/distro/S/SHARYANTO-Number- > > Util.html?oncpan=1&distmat=1&version=0.56&grade=3

> > > > > > Any pointers?

> > > > Hi Steven, > > > > I don't know what's wrong here. You can go to the matrix instead to > > see > > the overview and click into the fail reports: > > http://matrix.cpantesters.org/?dist=SHARYANTO-Number-Util+0.56 > > > > You can access the matrix via the "grid" symbol on metacpan.org, or > > via > > the "Perl/Platform Version Matrix" link on search.cpan.org. > > > > A quick look into your code shows the following: > > > > - The module is using "use locale". I am not sure if you really want > > this. Note also that "use locale" is effective for the LC_NUMERIC > > locale since 5.19.9 or so. This means printf with a "%f" specifier > > under a German locale will use a dot for earlier perl versions, and > > a > > comma for future perl versions. > > > > - You try to protect yourself using $ENV{LANG}="C" in the test. This > > works only if the user sets only LANG. But the LC_ALL or LC_NUMERIC > > environment variables are "stronger" than LANG. Best is to set > > LC_ALL, > > at least for Linux and FreeBSD. > > > > Regards, > > Slaven > >

> > > > > > Regards, > > > Steven > > > > > > > > > On Mon, Apr 7, 2014 at 3:09 AM, Slaven_Rezic via RT < > > > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: > > >

> > >> Sun Apr 06 16:09:41 2014: Request 94487 was acted upon. > > >> Transaction: Ticket created by SREZIC > > >> Queue: SHARYANTO-Number-Util > > >> Subject: Tests fail with bleadperl > > >> Broken in: 0.56 > > >> Severity: (no value) > > >> Owner: Nobody > > >> Requestors: SREZIC@cpan.org > > >> Status: new > > >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > >> > > >> > > >> Just FYI... tests fail with latest perls for some locales, e.g. > > >> German > > >> locales. > > >> > > >> Regards, > > >> Slaven > > >>

> > >

> > > > -- > > Slaven Rezic - slaven <at> rezic <dot> de > > > > Berlin Perl Mongers - http://berlin.pm.org > > > >

Mon Apr 28 00:35:53 2014 sharyanto [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Apr 30 02:05:13 2014 SREZIC [...] cpan.org - Correspondence added

On 2014-04-28 00:35:52, SHARYANTO wrote: Show quoted text

> I'm not seeing any more failure reports, so closing ticket. >

I have to reopen: there are still failures with bleedperl. Maybe setting any of LC_ALL or LANG is too late at this point, and have to be done very early in a BEGIN block? Or you have to use POSIX::setlocale? Regards, Slaven Show quoted text

> Regards, > Steven > > On Sun Apr 06 17:24:53 2014, stevenharyanto@gmail.com wrote:

> > Hi Slaven, > > > > I do have to "use locale" to produce a comma for German or Indonesian > > locale. Otherwise perl will still use C locale. Haven't tried 5.19.9+ > > though (am compiling 5.19.10 with perlbrew as I am writing this). > > > > Changed LANG to LC_ALL. Thanks. > > > > Regards, > > Steven > > > > > > On Mon, Apr 7, 2014 at 4:08 AM, slaven@rezic.de via RT < > > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: > >

> > > Queue: SHARYANTO-Number-Util > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > > > > "Steven Haryanto via RT" <bug-SHARYANTO-Number-Util@rt.cpan.org> > > > writes: > > >

> > > > <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > > > > > > Hi Slaven, > > > > > > > > CPANTesters.org says there are 5 fail reports, but I can't seem to > > > > get

> > > the

> > > > actual error reports. > > > > > > > >

> > > http://www.cpantesters.org/distro/S/SHARYANTO-Number- > > > Util.html?oncpan=1&distmat=1&version=0.56&grade=3

> > > > > > > > Any pointers?

> > > > > > Hi Steven, > > > > > > I don't know what's wrong here. You can go to the matrix instead to > > > see > > > the overview and click into the fail reports: > > > http://matrix.cpantesters.org/?dist=SHARYANTO-Number-Util+0.56 > > > > > > You can access the matrix via the "grid" symbol on metacpan.org, or > > > via > > > the "Perl/Platform Version Matrix" link on search.cpan.org. > > > > > > A quick look into your code shows the following: > > > > > > - The module is using "use locale". I am not sure if you really want > > > this. Note also that "use locale" is effective for the LC_NUMERIC > > > locale since 5.19.9 or so. This means printf with a "%f" specifier > > > under a German locale will use a dot for earlier perl versions, and > > > a > > > comma for future perl versions. > > > > > > - You try to protect yourself using $ENV{LANG}="C" in the test. This > > > works only if the user sets only LANG. But the LC_ALL or LC_NUMERIC > > > environment variables are "stronger" than LANG. Best is to set > > > LC_ALL, > > > at least for Linux and FreeBSD. > > > > > > Regards, > > > Slaven > > >

> > > > > > > > Regards, > > > > Steven > > > > > > > > > > > > On Mon, Apr 7, 2014 at 3:09 AM, Slaven_Rezic via RT < > > > > bug-SHARYANTO-Number-Util@rt.cpan.org> wrote: > > > >

> > > >> Sun Apr 06 16:09:41 2014: Request 94487 was acted upon. > > > >> Transaction: Ticket created by SREZIC > > > >> Queue: SHARYANTO-Number-Util > > > >> Subject: Tests fail with bleadperl > > > >> Broken in: 0.56 > > > >> Severity: (no value) > > > >> Owner: Nobody > > > >> Requestors: SREZIC@cpan.org > > > >> Status: new > > > >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94487 > > > > >> > > > >> > > > >> Just FYI... tests fail with latest perls for some locales, e.g. > > > >> German > > > >> locales. > > > >> > > > >> Regards, > > > >> Slaven > > > >>

> > > >

> > > > > > -- > > > Slaven Rezic - slaven <at> rezic <dot> de > > > > > > Berlin Perl Mongers - http://berlin.pm.org > > > > > >

> >

Wed Apr 30 02:05:14 2014 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Thu May 01 12:24:59 2014 sharyanto [...] cpan.org - Correspondence added

Ok, let's try that. Released 0.58. Regards, Steven On Wed Apr 30 02:05:13 2014, SREZIC wrote: Show quoted text

> On 2014-04-28 00:35:52, SHARYANTO wrote:

> > I'm not seeing any more failure reports, so closing ticket. > >

> > I have to reopen: there are still failures with bleedperl. > > Maybe setting any of LC_ALL or LANG is too late at this point, and > have to be done very early in a BEGIN block? > Or you have to use POSIX::setlocale? > > Regards, > Slaven >

> > Regards, > > Steven

Thu May 01 12:24:59 2014 sharyanto [...] cpan.org - Status changed from 'open' to 'resolved'