Subject: | Multiple issues with new public suffix tests |
I've been struggling to build the 1.976 release, with several issues in the new public suffix tests.
The code is supporting multiple IDN backends, but from my testing I was only able to get the tests to pass using URI::_idna.
With Net::IDN::Encode (2.003), I got:
disallowed character U+0095 at /usr/lib64/perl5/vendor_perl/Net/IDN/Encode.pm line 46.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 81.
t/public_suffix_lib.t ......
Dubious, test returned 255 (wstat 65280, 0xff00)
All 81 subtests passed
t/public_suffix_ssl.t ...... ok
With Net::LibIDN (), I got:
Use of uninitialized value $name in lc at /builddir/build/BUILD/IO-Socket-SSL-1.976/blib/lib/IO/Socket/SSL/PublicSuffix.pm line 211.
# Failed test at t/public_suffix_lib.t line 179.
# got: undef
# expected: '敎育.hk'
# Failed test at t/public_suffix_lib.t line 180.
# got: ''
# expected: 'ਭਾਰਤ'
# Looks like you failed 2 tests of 83.
t/public_suffix_lib.t ......
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/83 subtests
t/public_suffix_ssl.t ...... ok
With old versions of OpenSSL, there were further issues:
# Failed test at t/public_suffix_lib.t line 179.
# got: undef
# expected: '敎育.hk'
# Failed test at t/public_suffix_lib.t line 180.
# got: ''
# expected: 'ਭਾਰਤ'
# Looks like you failed 2 tests of 83.
t/public_suffix_lib.t ......
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/83 subtests
# Failed test 'ssl www.bar.com against *.bar.com -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.foo.bar.com against *.foo.bar.com -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.foo.co.uk against *.foo.co.uk -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.foo.bl.uk against *.foo.bl.uk -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.bl.uk against *.bl.uk -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.foo.bar.kobe.jp against *.foo.bar.kobe.jp -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.city.kobe.jp against *.city.kobe.jp -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Failed test 'ssl www.foo.nodomain against *.foo.nodomain -> ok (Client side SNI not supported for this openssl)'
# at t/public_suffix_ssl.t line 79.
# got: '0'
# expected: '1'
# Looks like you failed 8 tests of 14.
t/public_suffix_ssl.t ......
Dubious, test returned 8 (wstat 2048, 0x800)
Failed 8/14 subtests
Finally, t/public_suffix_lib.t uses done_testing, which means it requires Test::More >= 0.88 and fails like this with older versions:
You tried to run a test without a plan at t/public_suffix_lib.t line 37.
t/public_suffix_lib.t ......
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run