Bug #94369 for XML-Writer: comparing 'self' eq $newOutput when $newOutput is undef

Tue Apr 01 15:06:22 2014 dekarl [...] spaetfruehstuecken.org - Ticket created

CC:	xmltv-devel [...] lists.sourceforge.net
Subject:	comparing 'self' eq $newOutput when $newOutput is undef
Date:	Tue, 01 Apr 2014 21:04:53 +0200
To:	bug-XML-Writer [...] rt.cpan.org
From:	Karl Dietz <dekarl [...] spaetfruehstuecken.org>

Hi, our nightly xmltv-tester at http://www.crustynet.org.uk/~xmltv-tester/sid/nightly/ started reporting an error in XML::Writer some time ago. (Most grabber had their last successful test run on 2013-08-26.) Show quoted text

> Use of uninitialized value $newOutput in string eq at

/usr/share/perl5/XML/Writer.pm line 473. The line (looking it up on the master branch at github) is Show quoted text

> if ( !ref($newOutput) && 'self' eq $newOutput ) {

After looking into it and coming up with a hopeful band aid to unbreak our tester I think the issue was introduced in https://github.com/josephw/xml-writer-perl/commit/2848dd3853fdb668ef3b2bc2a6ce808f37776479 and can be fixed by testing if $newOutput is defined Regards, Karl

Tue Apr 08 10:40:03 2014 joe [...] kafsemo.org - Correspondence added

Hi there. On Tue Apr 01 15:06:22 2014, dekarl@spaetfruehstuecken.org wrote: ... Show quoted text

> > Use of uninitialized value $newOutput in string eq at

> /usr/share/perl5/XML/Writer.pm line 473. > > The line (looking it up on the master branch at github) is

> > if ( !ref($newOutput) && 'self' eq $newOutput ) {

Oops; the test was there to make sure this worked but it wasn't checking for warnings. Fixed in a5f9e8e4.

Tue Apr 08 10:40:03 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Apr 08 10:40:04 2014 joe [...] kafsemo.org - Status changed from 'open' to 'resolved'