Bug #94231 for Locale-PO: Allow management of previous value of the translation

Thu Mar 27 03:15:45 2014 hertzog [...] debian.org - Ticket created

Subject:	Allow management of previous value of the translation
Date:	Thu, 27 Mar 2014 08:15:32 +0100
To:	bug-Locale-PO [...] rt.cpan.org
From:	Raphael Hertzog <hertzog [...] debian.org>

Hello, msgmerge --previous generates special comments with the (expected) former value of any new fuzzy string that it generates. This makes it easier for tools to show the difference and thus easier for translators to update their translation. It would be nice if Locale::PO made it easy to retrieve/set that value. Here's an example of entry with that previous value (line starting with "#|"): #. Tag: para #, fuzzy, no-c-format #| msgid "There's no official list of planned changes, and Debian never makes promises relating to technical goals of the coming versions. However, a few development trends can already be noted, and there are many reasons to believe they will turn into concrete results in the new version." msgid "There's no official list of planned changes, and Debian never makes promises relating to technical goals of the coming versions. However, a few development trends can already be noted, and we can try some bets on what might happen (or not)." msgstr "Non esiste una lista ufficiale di modifiche pianificate, e Debian non fa promesse su obiettivi tecnici per le versioni future. Tuttavia, si possono notare alcuni trend di sviluppo, e ci sono molte ragioni per credere che si trasformeranno in risultati concreti per la prossima versione." IIRC msgmerge also generates multi-lines variants of those previous msgid, they work like the regular msgid except that each line is always prefixed with "#|". Cheers, -- Raphaël Hertzog ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/

Thu Mar 27 03:34:42 2014 cosimo [...] cpan.org - Correspondence added

Il Gio 27 Mar 2014 03:15:45, hertzog@debian.org ha scritto: Show quoted text

> Here's an example of entry with that previous value (line starting > with "#|"): > > #. Tag: para > #, fuzzy, no-c-format > #| msgid "There's no official list of planned changes, and Debian > never makes promises relating to technical goals of the coming > versions. However, a few development trends can already be noted, and > there are many reasons to believe they will turn into concrete results > in the new version." > msgid "There's no official list of planned changes, and Debian never > makes promises relating to technical goals of the coming versions. > However, a few development trends can already be noted, and we can try > some bets on what might happen (or not)." > msgstr "Non esiste una lista ufficiale di modifiche pianificate, e > Debian non fa promesse su obiettivi tecnici per le versioni future. > Tuttavia, si possono notare alcuni trend di sviluppo, e ci sono molte > ragioni per credere che si trasformeranno in risultati concreti per la > prossima versione." > > IIRC msgmerge also generates multi-lines variants of those previous > msgid, > they work like the regular msgid except that each line is always > prefixed > with "#|".

Thanks! I'm just working on a bug fix for RT#87374, so this is likely to happen soon. Any other lingering Debian patches I could bring in the module?

Thu Mar 27 03:34:42 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 27 03:41:19 2014 hertzog [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #94231] Allow management of previous value of the translation
Date:	Thu, 27 Mar 2014 08:41:04 +0100
To:	Cosimo Streppone via RT <bug-Locale-PO [...] rt.cpan.org>
From:	Raphael Hertzog <hertzog [...] debian.org>

On Thu, 27 Mar 2014, Cosimo Streppone via RT wrote: Show quoted text

> > IIRC msgmerge also generates multi-lines variants of those previous > > msgid, > > they work like the regular msgid except that each line is always > > prefixed > > with "#|".

> > Thanks! > > I'm just working on a bug fix for RT#87374, so this is likely to happen soon. > > Any other lingering Debian patches I could bring in the module?

http://packages.qa.debian.org/libl/liblocale-po-perl.html doesn't show any open bug on the Debian side, so it looks good. Thanks for taking care of this module! Cheers, -- Raphaël Hertzog ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/

Sun Dec 14 08:42:58 2014 cosimo [...] cpan.org - Correspondence added

Hi Rafael, I've squashed all filed bugs on Locale::PO except this one now :-) Please can you attach an example of a PO file that has "#|" lines in it? Just want to build a test case with a real world file, maybe coming from Debian, that would make for a good test case I think.

Sun Dec 14 14:29:37 2014 hertzog [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #94231] Allow management of previous value of the translation
Date:	Sun, 14 Dec 2014 20:28:39 +0100
To:	Cosimo Streppone via RT <bug-Locale-PO [...] rt.cpan.org>
From:	Raphael Hertzog <hertzog [...] debian.org>

Hi, On Sun, 14 Dec 2014, Cosimo Streppone via RT wrote: Show quoted text

> I've squashed all filed bugs on Locale::PO except this one now :-) > Please can you attach an example of a PO file that has "#|" lines in it?

See for example here: http://anonscm.debian.org/cgit/debian-handbook/debian-handbook.git/plain/it-IT/01_the-debian-project.po?id=27ddd19ddba982751c5ede088e96bc780f0f9886 (also attached) Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/

Message body is not shown because sender requested not to inline it.

Mon Dec 15 07:52:56 2014 cosimo [...] cpan.org - Correspondence added

Hi Raphael, I looked into adding this functionality and I facepalmed as it is already there. Now I built a test case for it, but essentially the previous message id is being included with "#|" so it is the fuzzy_msgid(). Please have a look here: https://github.com/cosimo/perl5-locale-po/blob/master/t/RT94231.t IIUC this is the functionality you asked for? Thanks,

Mon Dec 15 09:33:24 2014 hertzog [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #94231] Allow management of previous value of the translation
Date:	Mon, 15 Dec 2014 15:33:06 +0100
To:	Cosimo Streppone via RT <bug-Locale-PO [...] rt.cpan.org>
From:	Raphael Hertzog <hertzog [...] debian.org>

Hi, On Mon, 15 Dec 2014, Cosimo Streppone via RT wrote: Show quoted text

> I looked into adding this functionality and I facepalmed as it is > already there. Now I built a test case for it, but essentially the > previous message id is being included with "#|" so it is the > fuzzy_msgid(). > > Please have a look here: > > https://github.com/cosimo/perl5-locale-po/blob/master/t/RT94231.t > > IIUC this is the functionality you asked for?

Can this function also be used to set the value and generate a PO file with such entries? Because that's the feature that is needed for Publican: https://bugzilla.redhat.com/show_bug.cgi?id=1034836 I just opened a new ticket given what you just said: https://bugzilla.redhat.com/show_bug.cgi?id=1174268 Otherwise, yes, it looks like what I need. Thank you! -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/

Mon Dec 15 10:57:31 2014 cosimo [...] cpan.org - Correspondence added

I've extended the test case for this ticket by adding sample code to modify an entry through $entry->fuzzy_msgid(), persisting it to disk and verifying that it is actually saved, so to me this functionality looks complete. https://github.com/cosimo/perl5-locale-po/commit/f1f486abfd0c9622f4ee9e5d9b582e37c7d86b2a I'll consider this ticket closed then.

Mon Dec 15 10:57:32 2014 cosimo [...] cpan.org - Status changed from 'open' to 'resolved'