Bug #94213 for Net-SSLeay: unwise overriding of configured compiler flags

Wed Mar 26 10:25:21 2014 zefram [...] fysh.org - Ticket created

Subject:	unwise overriding of configured compiler flags
Date:	Wed, 26 Mar 2014 14:25:06 +0000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

Net-SSLeay overrides Perl's configured C compiler optimisation flags, to no apparent purpose. It should generally respect the configured flags, overriding only where specifically necessary. -zefram

Mon Mar 31 21:04:46 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #94213] unwise overriding of configured compiler flags
Date:	Tue, 01 Apr 2014 11:04:33 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, thanks for your report. Would you care to submit a patch? Cheers. On Wednesday, March 26, 2014 10:25:22 AM you wrote: Show quoted text

> Wed Mar 26 10:25:21 2014: Request 94213 was acted upon. > Transaction: Ticket created by zefram@fysh.org > Queue: Net-SSLeay > Subject: unwise overriding of configured compiler flags > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: zefram@fysh.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94213 > > > > Net-SSLeay overrides Perl's configured C compiler optimisation flags, to > no apparent purpose. It should generally respect the configured flags, > overriding only where specifically necessary. > > -zefram

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070

Mon Mar 31 21:04:48 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Apr 01 02:15:32 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #94213] unwise overriding of configured compiler flags
Date:	Tue, 01 Apr 2014 16:15:19 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi again. Never mind. Suitable changes (I think ) in SVN revision 400 The overriding was mostly to do with suporting special HPUX compiler flags, so I would welcome tests of the latest SVN version from anyone running HPUX. Cheers. On Tuesday, April 01, 2014 11:04:33 AM Mike McCauley wrote: Show quoted text

> Hi, > > thanks for your report. > > Would you care to submit a patch? > > Cheers. > > On Wednesday, March 26, 2014 10:25:22 AM you wrote:

> > Wed Mar 26 10:25:21 2014: Request 94213 was acted upon. > > Transaction: Ticket created by zefram@fysh.org > > > > Queue: Net-SSLeay > > > > Subject: unwise overriding of configured compiler flags > > > > Broken in: (no value) > > > > Severity: (no value) > > > > Owner: Nobody > > > > Requestors: zefram@fysh.org > > > > Status: new > > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94213 > > > > > Net-SSLeay overrides Perl's configured C compiler optimisation flags, to > > no apparent purpose. It should generally respect the configured flags, > > overriding only where specifically necessary. > > > > -zefram

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070

Tue Apr 01 04:55:14 2014 zefram [...] fysh.org - Correspondence added

Subject:	Re: [rt.cpan.org #94213] unwise overriding of configured compiler flags
Date:	Tue, 1 Apr 2014 09:55:01 +0100
To:	Mike McCauley via RT <bug-Net-SSLeay [...] rt.cpan.org>
From:	Zefram <zefram [...] fysh.org>

Mike McCauley via RT wrote: Show quoted text

>Suitable changes (I think ) in SVN revision 400

This looks a bit dubious, because in the non-HPUX case you're not initialising $opts->{optimize} at all, but still go on to pass (OPTIMIZE => $opts->{optimize}) to $self->makemaker_args. However, empirically EU:MM uses the core-configured flags in that case, rather than a blank set of flags. Same goes for CCCDLFLAGS, which you initialise as an empty string. So I guess that's all right. The EU:MM behaviour isn't documented, but is unlikely to change. -zefram

Tue Apr 01 05:19:56 2014 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #94213] unwise overriding of configured compiler flags
Date:	Tue, 01 Apr 2014 19:19:43 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, On Tuesday, April 01, 2014 04:55:15 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=94213 > > > Mike McCauley via RT wrote:

> >Suitable changes (I think ) in SVN revision 400

> > This looks a bit dubious, because in the non-HPUX case you're not > initialising $opts->{optimize} at all, but still go on to pass (OPTIMIZE > => $opts->{optimize}) to $self->makemaker_args. However, empirically > EU:MM uses the core-configured flags in that case, rather than a blank > set of flags. Same goes for CCCDLFLAGS, which you initialise as an > empty string. So I guess that's all right. The EU:MM behaviour isn't > documented, but is unlikely to change.

My tests show that OPTIMIZE => '' results in the default perl optimization. Cheers. Show quoted text

> > -zefram

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070

Sat May 24 03:27:50 2014 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Sat May 24 03:27:51 2014 MIKEM [...] cpan.org - Taken