| Subject: | [patch] Bug in PatchReader 0.9.6 Raw.pm |
| Date: | Tue, 25 Mar 2014 10:16:08 -0400 |
| To: | bug-PatchReader [...] rt.cpan.org |
| From: | Denis Roy <denis.roy [...] eclipse.org> |
Hi,
We've found a bug in Raw.pm when the filename or path contains a space.
Patch:
--- old/Raw.pm 2011-04-11 02:06:40.000000000 -0400
+++ Raw.pm 2014-03-24 11:36:51.000000000 -0400
@@ -41,7 +41,8 @@
return if $line =~ /^\?/;
# patch header parsing
- if ($line =~ /^---\s*([\S ]+)\s*\t([^\t\r\n]*)\s*(\S*)/) {
+ # if ($line =~ /^---\s*([\S ]+)\s*\t([^\t\r\n]*)\s*(\S*)/) {
+ if ($line =~ /^---\s*([\S ]+)\s*?(?:\t([^\t\r\n]*)\s*(\S*))?/) {
$this->_maybe_end_file();
if ($1 eq "/dev/null") {
We've tested it on a sandbox bugzilla, here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399391
Thanks for considering.
Denis