Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 94087
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/20_policies.t fail on 5.19.10
Date: Fri, 21 Mar 2014 14:34:58 +0000
To: bug-Perl-Critic [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
On Perl 5.19.10: t/20_policies.t ............................... 705/2675 # Failed test 'Modules::RequireVersionVar - line 72 - Readonly VERSION' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: No package-scoped "$VERSION" variable found at line 1, column 1. () # Failed test 'Modules::RequireVersionVar - line 80 - Readonly::Scalar VERSION' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: No package-scoped "$VERSION" variable found at line 1, column 1. () # Failed test 'NamingConventions::Capitalization - line 53 - Special case: main' # at t/20_policies.t line 27. # Expected 0 violations, got 1. Found violations follow... # Found violation: Package "main" does not start with a upper case letter at line 2, column 1. (package main;) t/20_policies.t ............................... 2465/2675 # Failed test 'Variables::ProhibitPerl4PackageNames - line 230 - $POSTMATCH' # at t/20_policies.t line 27. # Expected 0 violations, got 2. Found violations follow... # Found violation: "$'" uses the obsolete single quote package separator." at line 2, column 8. ($foo = $';) # Found violation: "$'" uses the obsolete single quote package separator." at line 3, column 7. (print $';) t/20_policies.t ............................... 2661/2675 # Failed test 'Variables::RequireNegativeIndices - line 26 - Basic failure' # at t/20_policies.t line 27. # Expected 5 violations, got 0. # Failed test 'Variables::RequireNegativeIndices - line 38 - Complex failures' # at t/20_policies.t line 27. # Expected 8 violations, got 0. # Looks like you failed 6 tests of 2675. t/20_policies.t ............................... Dubious, test returned 6 (wstat 1536, 0x600) Failed 6/2675 subtests -zefram
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Date: Fri, 21 Mar 2014 15:31:53 +0000
To: Bugs in Perl-Critic via RT <bug-Perl-Critic [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Aaron Crane comments that this is almost certainly due to [perl #121484], as removing all the /m flags from the code makes the tests pass. -zefram
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Date: Tue, 25 Mar 2014 16:46:08 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey Ryan" <jeff [...] imaginative-software.com>
Thanks Zefram. I read #121484, and it sounds like the problem lies with 5.19 and fixed in commit 7742aa66. So no action should be required in Perl::Critic. Or have I misunderstood?
Subject: Re: [rt.cpan.org #94087] AutoReply: t/20_policies.t fail on 5.19.10
Date: Wed, 26 Mar 2014 06:39:13 +0000
To: Jeffrey Thalhammer via RT <bug-Perl-Critic [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Jeffrey Thalhammer via RT wrote: Show quoted text
>Thanks Zefram. I read #121484, and it sounds like the problem lies with >5.19 and fixed in commit 7742aa66. So no action should be required in >Perl::Critic. Or have I misunderstood?
No further action should be required. -zefram