Bug #93822 for Lingua-EN-Grammarian: Errors file not loaded when Cautions file available

Thu Mar 13 04:07:43 2014 brian.pat.kelly [...] googlemail.com - Ticket created

Subject:	Errors file not loaded when Cautions file available
Date:	Thu, 13 Mar 2014 08:07:26 +0000
To:	bug-lingua-en-grammarian [...] rt.cpan.org
From:	Brian Kelly <brian.pat.kelly [...] googlemail.com>

Hi, In version 0.000004 the errors file [{~,.,/usr/local/share}/grammarian_errors] does not seem to be getting loaded when the cautions file is available [{~,.,/usr/local/share}/grammarian_cautions]. This results in lots of 'uninitialised' warnings and no detection of errors (although cautions are detected) when run against the included demo.pl file: Use of uninitialized value $ERRORS_REGEX in regexp compilation at /Users/briankelly/perl5/lib/perl5/Lingua/EN/Grammarian.pm line 494, <> line 1292. Use of uninitialized value in subtraction (-) at /Users/briankelly/perl5/lib/perl5/Lingua/EN/Grammarian.pm line 644, <> line 1292. This impacts perl 5.10 and 5.16. I've attached a suggested patch. Best wishes, Brian

Message body is not shown because sender requested not to inline it.

Thu Mar 13 04:31:36 2014 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #93822] Errors file not loaded when Cautions file available
Date:	Thu, 13 Mar 2014 08:30:47 +0000
To:	bug-Lingua-EN-Grammarian [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks, Brian. Wow, that was a rookie mistake on my part! ;-) I've patched the problem and uploaded a new release to CPAN. Much appreciated! Damian

Thu Mar 13 04:31:36 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 13 04:38:58 2014 DCONWAY [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Mar 13 04:54:40 2014 brian.pat.kelly [...] googlemail.com - Correspondence added

Subject:	Re: [rt.cpan.org #93822] Errors file not loaded when Cautions file available
Date:	Thu, 13 Mar 2014 08:54:30 +0000
To:	bug-Lingua-EN-Grammarian [...] rt.cpan.org
From:	Brian Kelly <brian.pat.kelly [...] googlemail.com>

Thanks Damian, That was quick! Updated my version and will let you know if I find any other issues. Excellent talk @london.pm BTW. Best wishes, Brian On 13 March 2014 08:31, damian@conway.org via RT < bug-Lingua-EN-Grammarian@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=93822 > > > Thanks, Brian. > > Wow, that was a rookie mistake on my part! ;-) > > I've patched the problem and uploaded a new release to CPAN. > > Much appreciated! > > Damian > >

Thu Mar 13 06:41:13 2014 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #93822] Errors file not loaded when Cautions file available
Date:	Thu, 13 Mar 2014 10:36:42 +0000
To:	bug-lingua-en-grammarian <bug-Lingua-EN-Grammarian [...] rt.cpan.org>
From:	Damian Conway <damian [...] conway.org>

Show quoted text

> That was quick! Updated my version and will let you know if I find any > other issues.

Much appreciated, Brian! Show quoted text

> Excellent talk @london.pm BTW.

Thank-you. I had a great time giving it. Glad you enjoyed it too. :-) Damian

Thu Mar 13 06:41:17 2014 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #93822] Errors file not loaded when Cautions file available
Date:	Thu, 13 Mar 2014 10:36:42 +0000
To:	bug-lingua-en-grammarian <bug-Lingua-EN-Grammarian [...] rt.cpan.org>
From:	Damian Conway <damian [...] conway.org>

Show quoted text

> That was quick! Updated my version and will let you know if I find any > other issues.

Much appreciated, Brian! Show quoted text

> Excellent talk @london.pm BTW.

Thank-you. I had a great time giving it. Glad you enjoyed it too. :-) Damian