Skip Menu |

This queue is for tickets about the MooseX-Constructor-AllErrors CPAN distribution.

Report information
The Basics
Id: 93709
Status: resolved
Priority: 0/
Queue: MooseX-Constructor-AllErrors
People
Owner: ether [...] cpan.org
Requestors: DAKKAR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.023
Fixed in: 0.024

History Show all quoted text
  Mon Mar 10 11:23:15 2014 DAKKAR [...] cpan.org - Ticket created
Subject: Regression in the call to throw_error
Versions of ::AllErrors before 0.22 did: $meta->throw_error($error, params => $args); Then 0.22 replaced the call with a simple "die $error". 0.23 re-introduced the call, for compatibility with versions of Moose that implement custom error classes (and users of such versions). But the call has become: $meta->throw_error(message => $error); We lost the "params => $args" part. I'm locally patching our copy, but it would be nice to have this change in an official release. Thanks!
  Mon Mar 10 12:25:06 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #93709] Regression in the call to throw_error
Date: Mon, 10 Mar 2014 09:24:51 -0700
To: DAKKAR via RT <bug-MooseX-Constructor-AllErrors [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Mon, Mar 10, 2014 at 11:23:17AM -0400, DAKKAR via RT wrote: Show quoted text
> Versions of ::AllErrors before 0.22 did: > > $meta->throw_error($error, params => $args); > > Then 0.22 replaced the call with a simple "die $error". > > 0.23 re-introduced the call, for compatibility with versions of Moose that implement custom error classes (and users of such versions). But the call has become: > > $meta->throw_error(message => $error); > > We lost the "params => $args" part. > > I'm locally patching our copy, but it would be nice to have this change in an official release. > > Thanks!
Doh, that was an oversight! I should be able to release this in the next few days.
  Mon Mar 10 12:25:06 2014 The RT System itself - Status changed from 'new' to 'open'
  Mon Mar 10 22:23:10 2014 ether [...] cpan.org - Correspondence added
0.024 released. sorry again!
  Mon Mar 10 22:23:12 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Oct 23 18:08:07 2014 ether [...] cpan.org - Fixed in 0.024 added